fix: deprecated code in new credential sync endpoints#14116
Conversation
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
Bot
added
High priority
keithwillcode
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (03/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 303 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/16/2024 07:00:45pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: aa5339f Started: 03/16/2024 06:51:13pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user1NotMemberOfOrg1 is part of team1MemberOfOrg1 EventTypes listing should show correct link for user events and team1MemberOfOrg1's events
Retry 1 • Initial Attempt |
2.75% (5)5 / 182 runsfailed over last 7 days |
6.04% (11)11 / 182 runsflaked over last 7 days |
| const { userId: reqUserId, credentialId: reqCredentialId } = schemaCredentialDeleteParams.parse(req.query); | ||
|
|
||
| const userId = parseInt(reqUserId); | ||
| const credentialId = parseInt(reqCredentialId); |
There was a problem hiding this comment.
The schema already returns as number.
| // createdcredential.user.email; | ||
| // TODO: ^ Investigate why this select doesn't work. |
There was a problem hiding this comment.
@joeauyeung Found some odd behavior in here. Seems like using a select or include in here doesn't actually returns the correct types. Tried replicating in other files and on a new repo with no luck. Also tried upgrading prisma to discard a possible bug but still didn't work. I had to create and find in two queries as a workaround.
3 participants
What does this PR do?
Fixes #14115
Type of change
How should this be tested?
yarn build --filter=@calcom/apiMandatory Tasks