Skip to content

feat: add 2fa removal for admins#14126

Merged
zomars merged 2 commits intomainfrom
feat/remove-2fa-admin
Mar 18, 2024
Merged

feat: add 2fa removal for admins#14126
zomars merged 2 commits intomainfrom
feat/remove-2fa-admin

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon commented Mar 18, 2024

@graphite-app graphite-app Bot requested a review from a team March 18, 2024 09:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 18, 2024
@linear
Copy link
Copy Markdown

linear Bot commented Mar 18, 2024

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 2:57pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 2:57pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 2:57pm
qa ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 2:57pm

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 18, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Mar 18, 2024

Current Playwright Test Results Summary

✅ 303 Passing - ⚠️ 15 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/18/2024 03:14:02pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 74c5a55

Started: 03/18/2024 03:06:57pm UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types Can create managed event type
Retry 1Initial Attempt
0% (0) 0 / 154 runs
failed over last 7 days
4.55% (7) 7 / 154 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2Retry 1Initial Attempt
3.33% (6) 6 / 180 runs
failed over last 7 days
24.44% (44) 44 / 180 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
7.14% (14) 14 / 196 runs
failed over last 7 days
34.69% (68) 68 / 196 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be rescheduled
Retry 2Retry 1Initial Attempt
1.10% (2) 2 / 182 runs
failed over last 7 days
3.30% (6) 6 / 182 runs
flaked over last 7 days

📄   apps/web/playwright/insights.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Insights should be able to go to insights as admins
Retry 1Initial Attempt
0.54% (1) 1 / 184 run
failed over last 7 days
6.52% (12) 12 / 184 runs
flaked over last 7 days
Insights should be able to go to insights as members
Retry 1Initial Attempt
0% (0) 0 / 183 runs
failed over last 7 days
2.73% (5) 5 / 183 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity it can delete date overrides
Retry 1Initial Attempt
2.47% (2) 2 / 81 runs
failed over last 7 days
43.21% (35) 35 / 81 runs
flaked over last 7 days

📄   apps/web/playwright/apps/analytics/analyticsApps.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check analytics Apps Check analytics Apps
Retry 1Initial Attempt
1.60% (3) 3 / 187 runs
failed over last 7 days
5.88% (11) 11 / 187 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
8.84% (16) 16 / 181 runs
failed over last 7 days
23.20% (42) 42 / 181 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can duplicate an existing event type
Retry 1Initial Attempt
0% (0) 0 / 185 runs
failed over last 7 days
10.27% (19) 19 / 185 runs
flaked over last 7 days
Event Types tests -- future user Different Locations Tests Can add Cal video location and book with it
Retry 1Initial Attempt
0.54% (1) 1 / 185 run
failed over last 7 days
1.62% (3) 3 / 185 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Signup with valid (non premium) username
Retry 1Initial Attempt
2.58% (5) 5 / 194 runs
failed over last 7 days
9.79% (19) 19 / 194 runs
flaked over last 7 days

📄   apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change username on settings User can change username to include periods(or dots)
Retry 1Initial Attempt
0% (0) 0 / 188 runs
failed over last 7 days
6.38% (12) 12 / 188 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 187 runs
failed over last 7 days
33.69% (63) 63 / 187 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
1.60% (3) 3 / 188 runs
failed over last 7 days
44.68% (84) 84 / 188 runs
flaked over last 7 days

View Detailed Build Results


@Udit-takkar Udit-takkar added this to the v4.0 milestone Mar 18, 2024
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but i can't find the dropdown

Screenshot 2024-03-18 at 7 23 50 PM

@sean-brydon
Copy link
Copy Markdown
Member Author

Code looks good but i can't find the dropdown

Screenshot 2024-03-18 at 7 23 50 PM

tf - is it there on prod for you? this PR shouldnt have changed anything to do with the rendering of that dropdown

@Udit-takkar
Copy link
Copy Markdown
Contributor

tf - is it there on prod for you? this PR shouldnt have changed anything to do with the rendering of that dropdown

I see dropdown and other columns on prod. probably something wrong with my local setup

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a star. 🙏🏽

@zomars zomars merged commit 9694aa4 into main Mar 18, 2024
@zomars zomars deleted the feat/remove-2fa-admin branch March 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants