fix: email embed displaying wrong date#14128
Merged
Udit-takkar merged 1 commit intomainfrom Mar 18, 2024
Merged
Conversation
github-actions
Bot
added
emails
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 299 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/18/2024 11:39:43am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: bd74910 Started: 03/18/2024 11:30:01am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types Can create managed event type
Retry 1 • Initial Attempt |
0% (0)0 / 146 runsfailed over last 7 days |
4.11% (6)6 / 146 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 176 runsfailed over last 7 days |
5.68% (10)10 / 176 runsflaked over last 7 days |
📄 apps/web/playwright/change-username.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change username on settings User can change username
Retry 1 • Initial Attempt |
0.55% (1)1 / 181 runfailed over last 7 days |
4.42% (8)8 / 181 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.11% (2)2 / 180 runsfailed over last 7 days |
44.44% (80)80 / 180 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-81.63% (-80)-80 / 98 runsfailed over last 7 days |
81.63% (80)80 / 98 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-82.47% (-80)-80 / 97 runsfailed over last 7 days |
82.47% (80)80 / 97 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-80.41% (-78)-78 / 97 runsfailed over last 7 days |
81.44% (79)79 / 97 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
6.95% (13)13 / 187 runsfailed over last 7 days |
35.83% (67)67 / 187 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity it can delete date overrides
Retry 1 • Initial Attempt |
2.74% (2)2 / 73 runsfailed over last 7 days |
42.47% (31)31 / 73 runsflaked over last 7 days |
Current Playwright Test Results Summary✅ 236 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/18/2024 11:39:40am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: bd74910 Started: 03/18/2024 11:30:01am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change username on settings User can change username
Retry 1 • Initial Attempt |
0.55% (1)1 / 181 runfailed over last 7 days |
4.42% (8)8 / 181 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.11% (2)2 / 180 runsfailed over last 7 days |
44.44% (80)80 / 180 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-81.63% (-80)-80 / 98 runsfailed over last 7 days |
81.63% (80)80 / 98 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-82.47% (-80)-80 / 97 runsfailed over last 7 days |
82.47% (80)80 / 97 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-80.41% (-78)-78 / 97 runsfailed over last 7 days |
81.44% (79)79 / 97 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-82.29% (-79)-79 / 96 runsfailed over last 7 days |
82.29% (79)79 / 96 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
6.95% (13)13 / 187 runsfailed over last 7 days |
35.83% (67)67 / 187 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity it can delete date overrides
Retry 1 • Initial Attempt |
2.74% (2)2 / 73 runsfailed over last 7 days |
42.47% (31)31 / 73 runsflaked over last 7 days |
joeauyeung
approved these changes
Mar 18, 2024
Contributor
joeauyeung
left a comment
joeauyeung
left a comment
There was a problem hiding this comment.
LGTM. Good catch @Udit-takkar!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13776
How to reproduce the bug?
Type of change