fix: booking limits for team event types#14135
Merged
Udit-takkar merged 2 commits intomainfrom Mar 19, 2024
Merged
Conversation
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
CarinaWolli
commented
Mar 18, 2024
| busyTimesFromLimitsBookings: busyTimesFromLimitsBookingsAllUsers.filter( | ||
| (b) => b.userId === currentUser.id | ||
| ), | ||
| busyTimesFromLimitsBookings: busyTimesFromLimitsBookingsAllUsers, |
Member
Author
There was a problem hiding this comment.
The booking limit is event type wide and it doesn't matter which user was booked.
Current Playwright Test Results Summary✅ 303 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/18/2024 11:35:26pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a7a5d2a Started: 03/18/2024 11:31:55pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- future Time slots should be reserved when selected
Retry 1 • Initial Attempt |
0% (0)0 / 201 runsfailed over last 7 days |
6.47% (13)13 / 201 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user can add multiple organizer address
Retry 1 • Initial Attempt |
0% (0)0 / 201 runsfailed over last 7 days |
1.99% (4)4 / 201 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity Can manage single schedule
Retry 1 • Initial Attempt |
0% (0)0 / 97 runsfailed over last 7 days |
10.31% (10)10 / 97 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt |
4.06% (8)8 / 197 runsfailed over last 7 days |
25.38% (50)50 / 197 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization
Retry 1 • Initial Attempt |
0.99% (2)2 / 202 runsfailed over last 7 days |
14.36% (29)29 / 202 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 204 runsfailed over last 7 days |
35.78% (73)73 / 204 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.97% (2)2 / 206 runsfailed over last 7 days |
45.15% (93)93 / 206 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-83.78% (-93)-93 / 111 runsfailed over last 7 days |
83.78% (93)93 / 111 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-84.55% (-93)-93 / 110 runsfailed over last 7 days |
84.55% (93)93 / 110 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-82.73% (-91)-91 / 110 runsfailed over last 7 days |
83.64% (92)92 / 110 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-84.40% (-92)-92 / 109 runsfailed over last 7 days |
84.40% (92)92 / 109 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-84.40% (-92)-92 / 109 runsfailed over last 7 days |
84.40% (92)92 / 109 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-84.40% (-92)-92 / 109 runsfailed over last 7 days |
84.40% (92)92 / 109 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-84.40% (-92)-92 / 109 runsfailed over last 7 days |
84.40% (92)92 / 109 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
1.46% (3)3 / 206 runsfailed over last 7 days |
47.09% (97)97 / 206 runsflaked over last 7 days |
Udit-takkar
approved these changes
Mar 19, 2024
Contributor
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
LGTM. Tested and worked fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a bug for team event types with booking limits enabled. Slots were shown as available even though the limit was already reached. When trying to book the slot it was throwing "Booking Limit for this event type has been reached"
Type of change
How should this be tested?