Skip to content

fix: Minor UI fix to team profile / fallback to parent org logo#14143

Merged
emrysal merged 1 commit intomainfrom
bugfix/organisation-avatar-team-listing
Mar 19, 2024
Merged

fix: Minor UI fix to team profile / fallback to parent org logo#14143
emrysal merged 1 commit intomainfrom
bugfix/organisation-avatar-team-listing

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Mar 19, 2024

What does this PR do?

  • Show the organisation avatar for subteams (if not has logo, show parent logo, if no parent logo - default)
  • Fix too much margin UI issue in sub team profiles.

@emrysal emrysal added the 🐛 bug Something isn't working label Mar 19, 2024
@emrysal emrysal requested a review from PeerRich March 19, 2024 13:10
@graphite-app graphite-app Bot requested a review from a team March 19, 2024 13:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only foundation labels Mar 19, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 19, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (03/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 1:11pm

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Mar 19, 2024

Current Playwright Test Results Summary

✅ 303 Passing - ⚠️ 14 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/19/2024 01:26:02pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 30c0b22

Started: 03/19/2024 01:21:00pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user can add multiple organizer address
Retry 1Initial Attempt
0% (0) 0 / 203 runs
failed over last 7 days
2.46% (5) 5 / 203 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
0% (0) 0 / 202 runs
failed over last 7 days
18.32% (37) 37 / 202 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
4.04% (8) 8 / 198 runs
failed over last 7 days
27.78% (55) 55 / 198 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity it can delete date overrides
Retry 2Retry 1Initial Attempt
2.65% (3) 3 / 113 runs
failed over last 7 days
43.36% (49) 49 / 113 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
6.06% (12) 12 / 198 runs
failed over last 7 days
24.75% (49) 49 / 198 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to an organization
Retry 1Initial Attempt
0.50% (1) 1 / 202 run
failed over last 7 days
9.90% (20) 20 / 202 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.45% (3) 3 / 207 runs
failed over last 7 days
45.41% (94) 94 / 207 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-85.45% (-94) -94 / 110 runs
failed over last 7 days
85.45% (94) 94 / 110 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-86.24% (-94) -94 / 109 runs
failed over last 7 days
86.24% (94) 94 / 109 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-84.40% (-92) -92 / 109 runs
failed over last 7 days
85.32% (93) 93 / 109 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-86.11% (-93) -93 / 108 runs
failed over last 7 days
86.11% (93) 93 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-86.11% (-93) -93 / 108 runs
failed over last 7 days
86.11% (93) 93 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-86.11% (-93) -93 / 108 runs
failed over last 7 days
86.11% (93) 93 / 108 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-86.11% (-93) -93 / 108 runs
failed over last 7 days
86.11% (93) 93 / 108 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit 8edf55f into main Mar 19, 2024
@emrysal emrysal deleted the bugfix/organisation-avatar-team-listing branch March 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only foundation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants