feat: platform endpoints to fetch/cancel/reschedule bookings and hooks#14164
Merged
feat: platform endpoints to fetch/cancel/reschedule bookings and hooks#14164
Conversation
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 303 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/27/2024 09:45:53am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 8e9e08f Started: 03/27/2024 09:42:38am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity Can manage single schedule
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 182 runsfailed over last 7 days |
7.69% (14)14 / 182 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 175 runsfailed over last 7 days |
5.71% (10)10 / 175 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
1.66% (3)3 / 181 runsfailed over last 7 days |
36.46% (66)66 / 181 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0% (0)0 / 177 runsfailed over last 7 days |
59.89% (106)106 / 177 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-149.30% (-106)-106 / 71 runsfailed over last 7 days |
149.30% (106)106 / 71 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-149.30% (-106)-106 / 71 runsfailed over last 7 days |
149.30% (106)106 / 71 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-149.30% (-106)-106 / 71 runsfailed over last 7 days |
149.30% (106)106 / 71 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-149.30% (-106)-106 / 71 runsfailed over last 7 days |
149.30% (106)106 / 71 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-149.30% (-106)-106 / 71 runsfailed over last 7 days |
149.30% (106)106 / 71 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-149.30% (-106)-106 / 71 runsfailed over last 7 days |
149.30% (106)106 / 71 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-149.30% (-106)-106 / 71 runsfailed over last 7 days |
149.30% (106)106 / 71 runsflaked over last 7 days |
supalarry
reviewed
Mar 22, 2024
| // note(Rajiv): currently this endpoint is atoms only | ||
| @Get("/:bookingUid") | ||
| async getBooking(@Param("bookingUid") bookingUid: string): Promise<ApiResponse<unknown>> { | ||
| const { bookingInfo } = await getBookingInfo(bookingUid); |
Contributor
There was a problem hiding this comment.
I see that "getBookingInfo" consists of "prisma.booking.findFirst" call from "apps/web/modules/bookings/views/bookings-single-view.getServerSideProps.tsx" - don't we also need to perform the rest of the operations e.g. eventType that is returned to frontend is transformed into final form in the get server side props:
const eventType = {
...eventTypeRaw,
periodStartDate: eventTypeRaw.periodStartDate?.toString() ?? null,
periodEndDate: eventTypeRaw.periodEndDate?.toString() ?? null,
metadata: EventTypeMetaDataSchema.parse(eventTypeRaw.metadata),
recurringEvent: parseRecurringEvent(eventTypeRaw.recurringEvent),
customInputs: customInputSchema.array().parse(eventTypeRaw.customInputs),
};
Contributor
There was a problem hiding this comment.
I think this is done because next.js getServerSideProps can't serialize dates and other data structures
supalarry
reviewed
Mar 22, 2024
…king success page
…/cal.com into fetch-bookings-endpoint-and-hooks
ThyMinimalDev
changed the title
ThyMinimalDev
changed the title
ThyMinimalDev
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?