refactor: OAuth creation form hide apps permissions#14264
Merged
Conversation
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/29/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (03/29/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 291 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/29/2024 10:34:06am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 9eb5014 Started: 03/29/2024 10:30:22am UTC
|
|
|
13 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-6.44% (-13)-13 / 202 runsfailed over last 7 days |
6.44% (13)13 / 202 runsflaked over last 7 days |
|
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-6.44% (-13)-13 / 202 runsfailed over last 7 days |
6.44% (13)13 / 202 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-5.94% (-12)-12 / 202 runsfailed over last 7 days |
6.44% (13)13 / 202 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-6.47% (-13)-13 / 201 runsfailed over last 7 days |
6.47% (13)13 / 201 runsflaked over last 7 days |
|
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-6.47% (-13)-13 / 201 runsfailed over last 7 days |
6.47% (13)13 / 201 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-6.47% (-13)-13 / 201 runsfailed over last 7 days |
6.47% (13)13 / 201 runsflaked over last 7 days |
|
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-5.97% (-12)-12 / 201 runsfailed over last 7 days |
6.47% (13)13 / 201 runsflaked over last 7 days |
|
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1 • Initial Attempt |
-6% (-12)-12 / 200 runsfailed over last 7 days |
6.50% (13)13 / 200 runsflaked over last 7 days |
|
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-6.53% (-13)-13 / 199 runsfailed over last 7 days |
6.53% (13)13 / 199 runsflaked over last 7 days |
|
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-6.57% (-13)-13 / 198 runsfailed over last 7 days |
6.57% (13)13 / 198 runsflaked over last 7 days |
|
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-6.57% (-13)-13 / 198 runsfailed over last 7 days |
6.57% (13)13 / 198 runsflaked over last 7 days |
|
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1 • Initial Attempt |
-4.04% (-8)-8 / 198 runsfailed over last 7 days |
6.57% (13)13 / 198 runsflaked over last 7 days |
|
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1 • Initial Attempt |
-3.13% (-6)-6 / 192 runsfailed over last 7 days |
6.77% (13)13 / 192 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Login and logout tests -- legacy Login flow validations -- legacy Should warn when user does not exist
Retry 1 • Initial Attempt |
0% (0)0 / 199 runsfailed over last 7 days |
2.51% (5)5 / 199 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
1.48% (3)3 / 203 runsfailed over last 7 days |
3.94% (8)8 / 203 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
4.17% (8)8 / 192 runsfailed over last 7 days |
33.33% (64)64 / 192 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.98% (2)2 / 204 runsfailed over last 7 days |
59.31% (121)121 / 204 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-149.38% (-121)-121 / 81 runsfailed over last 7 days |
149.38% (121)121 / 81 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-153.16% (-121)-121 / 79 runsfailed over last 7 days |
153.16% (121)121 / 79 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-153.16% (-121)-121 / 79 runsfailed over last 7 days |
153.16% (121)121 / 79 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-153.16% (-121)-121 / 79 runsfailed over last 7 days |
153.16% (121)121 / 79 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-153.16% (-121)-121 / 79 runsfailed over last 7 days |
153.16% (121)121 / 79 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-153.16% (-121)-121 / 79 runsfailed over last 7 days |
153.16% (121)121 / 79 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-153.16% (-121)-121 / 79 runsfailed over last 7 days |
153.16% (121)121 / 79 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.98% (2)2 / 204 runsfailed over last 7 days |
11.27% (23)23 / 204 runsflaked over last 7 days |
supalarry
added a commit
that referenced
this pull request
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not support apps in atoms / v2, so we can hide "Apps" permissions when creation OAuth client. I just commented out code so we can uncomment it later on.
Before:
After:
