Skip to content

chore: added event-types link to settings#14274

Merged
Udit-takkar merged 7 commits intomainfrom
14202-cal-3309-team-settings-link-to-event-types
May 27, 2024
Merged

chore: added event-types link to settings#14274
Udit-takkar merged 7 commits intomainfrom
14202-cal-3309-team-settings-link-to-event-types

Conversation

@PeerRich
Copy link
Copy Markdown
Member

havent tested but should work

@PeerRich PeerRich linked an issue Mar 31, 2024 that may be closed by this pull request
@linear
Copy link
Copy Markdown

linear Bot commented Mar 31, 2024

@graphite-app graphite-app Bot requested a review from a team March 31, 2024 00:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types ✨ feature New feature or request 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand labels Mar 31, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Mar 31, 2024
@PeerRich PeerRich removed the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Mar 31, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 9:31am
cal ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 9:31am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 9:31am
qa ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 9:31am

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 31, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/31/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Mar 31, 2024

Current Playwright Test Results Summary

✅ 321 Passing - ⚠️ 14 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/13/2024 07:05:01pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 80579c9

Started: 05/13/2024 07:02:18pm UTC

⚠️ Flakes

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0.64% (2) 2 / 312 runs
failed over last 7 days
39.74% (124) 124 / 312 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2Retry 1Initial Attempt
2.48% (8) 8 / 323 runs
failed over last 7 days
21.67% (70) 70 / 323 runs
flaked over last 7 days
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1Initial Attempt
7.12% (23) 23 / 323 runs
failed over last 7 days
26.63% (86) 86 / 323 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats Prevent attendees from cancel when having invalid URL params
Retry 1Initial Attempt
0% (0) 0 / 307 runs
failed over last 7 days
0.33% (1) 1 / 307 run
flaked over last 7 days
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1Initial Attempt
0% (0) 0 / 307 runs
failed over last 7 days
3.26% (10) 10 / 307 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
34.44% (124) 124 / 360 runs
failed over last 7 days
33.89% (122) 122 / 360 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- legacy login flow user & logout using dashboard
Retry 1Initial Attempt
0% (0) 0 / 314 runs
failed over last 7 days
17.52% (55) 55 / 314 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1Initial Attempt
0% (0) 0 / 312 runs
failed over last 7 days
55.13% (172) 172 / 312 runs
flaked over last 7 days
Namespacing Different namespaces can have different init configs
Retry 1Initial Attempt
0% (0) 0 / 311 runs
failed over last 7 days
55.63% (173) 173 / 311 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1Initial Attempt
0% (0) 0 / 312 runs
failed over last 7 days
57.05% (178) 178 / 312 runs
flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1Initial Attempt
0.96% (3) 3 / 312 runs
failed over last 7 days
55.77% (174) 174 / 312 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 1Initial Attempt
4.26% (2) 2 / 47 runs
failed over last 7 days
38.30% (18) 18 / 47 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user enabling recurring event comes with default options
Retry 1Initial Attempt
2.50% (8) 8 / 320 runs
failed over last 7 days
6.88% (22) 22 / 320 runs
flaked over last 7 days

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 2Retry 1Initial Attempt
15.69% (51) 51 / 325 runs
failed over last 7 days
42.77% (139) 139 / 325 runs
flaked over last 7 days

View Detailed Build Results


@github-actions github-actions Bot added the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Apr 5, 2024
@PeerRich PeerRich removed the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Apr 8, 2024
@PeerRich PeerRich added this to the v4.0 milestone Apr 8, 2024
@PeerRich PeerRich added the ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work label Apr 8, 2024
@github-actions github-actions Bot added the 🚨 needs approval This feature request has not been reviewed yet by the Product Team and needs approval beforehand label Apr 8, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions Bot added the Stale label Apr 30, 2024
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. pushed some changes

@Udit-takkar Udit-takkar enabled auto-merge May 27, 2024 09:32
@Udit-takkar Udit-takkar added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 360b729 May 27, 2024
@Udit-takkar Udit-takkar deleted the 14202-cal-3309-team-settings-link-to-event-types branch May 27, 2024 09:54
@shirazdole
Copy link
Copy Markdown

great add @PeerRich !

p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
* added event-types link

* fix: add item in settings layout

---------

Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Co-authored-by: Udit Takkar <udit222001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ✨ feature New feature or request Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work teams area: teams, round robin, collective, managed event-types 🚧 wip / in the making This is currently being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-3309] team settings: link to event-types

4 participants