fix: Embed - Get element click popup working for a descendant element #14749
Merged
sean-brydon merged 3 commits intomainfrom Apr 26, 2024
Merged
fix: Embed - Get element click popup working for a descendant element #14749sean-brydon merged 3 commits intomainfrom
sean-brydon merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hariombalhara and the rest of your teammates on |
hariombalhara
force-pushed
the
04-25-fix_child_element_click_popup
branch
from
85f232c to
e5a7ae2
Compare
hariombalhara
force-pushed
the
04-25-fix_child_element_click_popup
branch
from
e5a7ae2 to
0949c57
Compare
github-actions
bot
added
embed
hariombalhara
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/25/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Current Playwright Test Results Summary✅ 315 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/26/2024 02:36:27pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5bf26a6 Started: 04/26/2024 02:32:05pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting user form, triggers user webhook
Retry 1 • Initial Attempt |
0.55% (1)1 / 183 runfailed over last 7 days |
6.01% (11)11 / 183 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0.56% (1)1 / 179 runfailed over last 7 days |
22.35% (40)40 / 179 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
6.80% (14)14 / 206 runsfailed over last 7 days |
36.41% (75)75 / 206 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1 • Initial Attempt |
5.91% (13)13 / 220 runsfailed over last 7 days |
31.82% (70)70 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
1% (2)2 / 201 runsfailed over last 7 days |
38.81% (78)78 / 201 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 202 runsfailed over last 7 days |
51.49% (104)104 / 202 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0% (0)0 / 202 runsfailed over last 7 days |
50.50% (102)102 / 202 runsflaked over last 7 days |
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0.50% (1)1 / 202 runfailed over last 7 days |
50.99% (103)103 / 202 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 200 runsfailed over last 7 days |
50% (100)100 / 200 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
18.40% (39)39 / 212 runsfailed over last 7 days |
38.68% (82)82 / 212 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes
Top 1 Common Error Messages
|
|
9 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
16.67% (35)35 / 210 runsfailed over last 7 days |
53.81% (113)113 / 210 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-182.26% (-113)-113 / 62 runsfailed over last 7 days |
182.26% (113)113 / 62 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-180.65% (-112)-112 / 62 runsfailed over last 7 days |
180.65% (112)112 / 62 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-180.65% (-112)-112 / 62 runsfailed over last 7 days |
180.65% (112)112 / 62 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-180.65% (-112)-112 / 62 runsfailed over last 7 days |
180.65% (112)112 / 62 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-180.65% (-112)-112 / 62 runsfailed over last 7 days |
180.65% (112)112 / 62 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-180.65% (-112)-112 / 62 runsfailed over last 7 days |
180.65% (112)112 / 62 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-180.65% (-112)-112 / 62 runsfailed over last 7 days |
180.65% (112)112 / 62 runsflaked over last 7 days |
|
Popup Tests should open on clicking child element
Retry 1 • Initial Attempt |
0% (-3)-3 / 0 runsfailed over last 7 days |
0% (3)3 / 0 runsflaked over last 7 days |
📄 apps/web/playwright/organization/booking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
17.86% (40)40 / 224 runsfailed over last 7 days |
24.55% (55)55 / 224 runsflaked over last 7 days |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sean-brydon
approved these changes
Apr 26, 2024
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
If i tested it right - it worked <3 LGTM
p6l-richard
pushed a commit
to p6l-richard/cal.com-fork
that referenced
this pull request
Jul 22, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14748
Fixes CAL-3554
Type of change
How should this be tested?
See Loom
Mandatory Tasks