Skip to content

fix: Show error log in case of /event-types redirect#14960

Merged
sean-brydon merged 1 commit intomainfrom
05-09-fix_show_error_log
May 10, 2024
Merged

fix: Show error log in case of /event-types redirect#14960
sean-brydon merged 1 commit intomainfrom
05-09-fix_show_error_log

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented May 9, 2024

What does this PR do?

Any error(including an error due to migration wasn't logged). I spent some time figuring out why browsing to an event-type wasn't working as it was silently redirecting.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:20pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) May 9, 2024 1:20pm
calcom-web-canary ⬜️ Ignored (Inspect) May 9, 2024 1:20pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 9, 2024
@hariombalhara hariombalhara changed the title fix: Show error log fix: Show error log in case of /event-types redirect May 9, 2024
@hariombalhara hariombalhara requested a review from emrysal May 9, 2024 13:19
@hariombalhara hariombalhara marked this pull request as ready for review May 9, 2024 13:19
@graphite-app graphite-app Bot requested a review from a team May 9, 2024 13:19
@hariombalhara hariombalhara added this to the v4.1 milestone May 9, 2024
@dosubot dosubot Bot added event-types area: event types, event-types 🐛 bug Something isn't working labels May 9, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 9, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented May 9, 2024

Current Playwright Test Results Summary

✅ 3 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/10/2024 03:01:09am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 8cf325e

Started: 05/10/2024 03:00:50am UTC

⚠️ Flakes

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1Initial Attempt
18.28% (53) 53 / 290 runs
failed over last 7 days
40% (116) 116 / 290 runs
flaked over last 7 days

View Detailed Build Results


@sean-brydon sean-brydon merged commit a136511 into main May 10, 2024
@sean-brydon sean-brydon deleted the 05-09-fix_show_error_log branch May 10, 2024 07:47
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only event-types area: event types, event-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants