Skip to content

fix: Fixed email embed for team when specific times are chosen embeds the wrong URL#14975

Merged
CarinaWolli merged 2 commits intocalcom:mainfrom
vikrant845:fix/team-embed-url
May 10, 2024
Merged

fix: Fixed email embed for team when specific times are chosen embeds the wrong URL#14975
CarinaWolli merged 2 commits intocalcom:mainfrom
vikrant845:fix/team-embed-url

Conversation

@vikrant845
Copy link
Copy Markdown
Contributor

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • [*] I have self-reviewed the code (A decent size PR without self-review might be rejected)

How should this be tested?

  1. Set up a Team and add availability
  2. Go to team event and click the Embed button
  3. Click on Email embed
  4. Choose specific times to embed
  5. Paste into the email
  6. When clicking on each of the selected times, they go to the correct page.

Checklist

  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2024

@borawakevikrant is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label May 10, 2024
@graphite-app graphite-app Bot requested a review from a team May 10, 2024 13:48
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions Bot added embed area: embed, widget, react embed teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels May 10, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 10, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/10/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@CarinaWolli CarinaWolli enabled auto-merge (squash) May 10, 2024 14:02
@CarinaWolli CarinaWolli merged commit 039bf6d into calcom:main May 10, 2024
@vikrant845 vikrant845 deleted the fix/team-embed-url branch May 11, 2024 09:06
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
… the wrong URL (calcom#14975)

* Fixed team embed url

* Added comments

---------

Co-authored-by: borawakevikrant <borawakevikrant@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync embed area: embed, widget, react embed teams area: teams, round robin, collective, managed event-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email embed for team when specific times are chosen embeds the wrong URL

3 participants