feat: provide option to allow rescheduling with the same round-robin host#15132
feat: provide option to allow rescheduling with the same round-robin host#15132CarinaWolli merged 13 commits intocalcom:mainfrom
Conversation
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
Bot
added
event-types
Graphite Automations"Add community label" took an action on this PR • (05/20/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
Bot
added
the
bookings
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Sixty-nine Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
anikdhabal
changed the title
|
This PR is being marked as stale due to inactivity. |
Amit91848
left a comment
Amit91848
left a comment
There was a problem hiding this comment.
Not sure if this belongs on the booker page, should this be an option in the event type settings instead? Lmk what you think. Tagging @CarinaWolli as she created the issue.
Either way this would need tests, please make sure to add those @anikdhabal 🙌
|
This PR is being marked as stale due to inactivity. |
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
Unit tests are pending
Yes, this should be in the event-type settings. The team owning the event type should be able to decide if rescheduling should go to the same host or a new host. Sorry for not pointing that out more clearly in my issue description |
Thanks for the clarification |
keithwillcode
added
the
community-interns
CarinaWolli
added
High priority
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
If 'Reschedule with same Round-Robin host' is enabled we also should only load the slots where the original host is available. Now, when trying to book a slot where the user isn't available you are getting a No available users found error
6 participants
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist