Skip to content

fix: avatar on booking page#15190

Merged
Udit-takkar merged 5 commits intomainfrom
fix/booking-page-avatar
May 27, 2024
Merged

fix: avatar on booking page#15190
Udit-takkar merged 5 commits intomainfrom
fix/booking-page-avatar

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented May 24, 2024 •
edited
Loading

What does this PR do?

Need Help->
How to add test for this?

  1. Org user event type
    Screenshot 2024-05-24 at 2 47 35 PM

  2. Org team event type
    Screenshot 2024-05-24 at 2 48 16 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • N/A I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@linear
Copy link
Copy Markdown

linear Bot commented May 24, 2024

CAL-3801 Duplicate avatar on orgs booking page

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 24, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 24, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 8:05am
cal ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 8:05am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 8:05am

@github-actions github-actions Bot added booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working labels May 24, 2024
@github-actions github-actions Bot added the High priority Created by Linear-GitHub Sync label May 24, 2024
@Udit-takkar Udit-takkar marked this pull request as ready for review May 24, 2024 09:18
@graphite-app graphite-app Bot requested a review from a team May 24, 2024 09:18
@dosubot dosubot Bot added bookings area: bookings, availability, timezones, double booking event-types area: event types, event-types labels May 24, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 24, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@CarinaWolli CarinaWolli added this to the v4.2 milestone May 24, 2024
@emrysal emrysal enabled auto-merge May 24, 2024 16:53
emrysal
emrysal previously approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at adding a test for this; need a way to test the booking page from a vitest perspective (not e2e)

@emrysal emrysal added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@keithwillcode keithwillcode added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@keithwillcode keithwillcode added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@keithwillcode keithwillcode added this pull request to the merge queue May 25, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 25, 2024
@keithwillcode
Copy link
Copy Markdown
Contributor

keithwillcode commented May 25, 2024 •
edited
Loading

Looks like a few tests are failing consistently. https://github.com/calcom/cal.com/actions/runs/9232384427/job/25403582413
Notice: 3 failed
[@***com/web] › apps/web/playwright/teams.e2e.ts:40:7 › Teams - NonOrg -- future › Team Onboarding Invite Members
[@***com/web] › apps/web/playwright/unpublished.e2e.ts:75:7 › Unpublished › Organization sub-team event-type
[@***com/web] › apps/web/playwright/unpublished.e2e.ts:107:7 › Unpublished › Organization user event-type

@Udit-takkar Udit-takkar requested a review from emrysal May 27, 2024 08:06
@Udit-takkar
Copy link
Copy Markdown
Contributor Author

Udit-takkar commented May 27, 2024 •
edited
Loading

Fixed failing test

@emrysal emrysal added this pull request to the merge queue May 27, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 27, 2024
@Udit-takkar Udit-takkar added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 30f9f19 May 27, 2024
@Udit-takkar Udit-takkar deleted the fix/booking-page-avatar branch May 27, 2024 19:46
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
@Udit-takkar @p6l-richard
fix: avatar on booking page (calcom#15190)
fd0f5d8 
* fix: avatar on booking page

* chore

* fix: type err

* fix: unpublished org
@p6l-richard p6l-richard mentioned this pull request Jul 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal approved these changes

Assignees

No one assigned

Labels

booking-page area: booking page, public booking page, booker bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only event-types area: event types, event-types High priority Created by Linear-GitHub Sync

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

[CAL-3801] Duplicate avatar on orgs booking page

4 participants

@Udit-takkar @keithwillcode @emrysal @CarinaWolli