Skip to content

fix: Profile page crash due to invalid topLevelElement#15198

Merged
emrysal merged 1 commit intomainfrom
bugfix/3804-fix-bio-profile-page-crash
May 24, 2024
Merged

fix: Profile page crash due to invalid topLevelElement#15198
emrysal merged 1 commit intomainfrom
bugfix/3804-fix-bio-profile-page-crash

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented May 24, 2024

What does this PR do?

Fixes that adding unterminated nodes like
can crash the profile page.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@CarinaWolli are there tests to cover the Editor?

@emrysal emrysal requested a review from CarinaWolli May 24, 2024 15:12
@linear
Copy link
Copy Markdown

linear Bot commented May 24, 2024

@graphite-app graphite-app Bot requested a review from a team May 24, 2024 15:12
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions Bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels May 24, 2024
@keithwillcode keithwillcode added core area: core, team members only foundation labels May 24, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 3:13pm

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 24, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (05/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@CarinaWolli
Copy link
Copy Markdown
Member

@CarinaWolli are there tests to cover the Editor?

No tests, I created an issue: #15199

@CarinaWolli CarinaWolli added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@keithwillcode keithwillcode added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@emrysal emrysal added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 5d32549 May 24, 2024
@emrysal emrysal deleted the bugfix/3804-fix-bio-profile-page-crash branch May 24, 2024 16:28
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only foundation ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-3804] Adding unterminated nodes like <br> can crash the profile page.

3 participants