Skip to content

feat: jelly seamless signup#15220

Merged
emrysal merged 5 commits intomainfrom
feat/jelly-seamless-signup
May 28, 2024
Merged

feat: jelly seamless signup#15220
emrysal merged 5 commits intomainfrom
feat/jelly-seamless-signup

Conversation

@ibex088
Copy link
Copy Markdown
Contributor

@ibex088 ibex088 commented May 28, 2024 •
edited
Loading

What does this PR do?

https://www.loom.com/share/2670f525fe274ef9989590e7d4dc05c8?sid=c5577233-a22f-411a-976c-df635539fac8

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • (N/A) - I have added a Docs issue here if this PR makes changes that would require a documentation change
  • (N/A) - I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • set jelly app client_id and client_secret in the admin panel (reach out to me if you don't have them)
  • got to http://localhost:3000/apps/jelly?defaultInstall=true
  • As seen in the Loom recording, after the OAuth process is completed and redirected back to the callback function, an error sometimes occurs. If this happens, please click the authorize button again. It is unclear if this is a local issue or a production bug.

@linear
Copy link
Copy Markdown

linear Bot commented May 28, 2024

CAL-3803 Jelly seamless signup

@graphite-app graphite-app Bot requested a review from a team May 28, 2024 11:38
@github-actions github-actions Bot added the High priority Created by Linear-GitHub Sync label May 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 28, 2024
@dosubot dosubot Bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar event-types area: event types, event-types ✨ feature New feature or request labels May 28, 2024
@dosubot dosubot Bot added this to the v4.2 milestone May 28, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 28, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:12pm
cal ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:12pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:12pm

@github-actions github-actions Bot added Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels May 28, 2024
keithwillcode
keithwillcode reviewed May 28, 2024
View reviewed changes
Comment thread packages/app-store/_utils/setDefaultConferencingApp.ts
const credentialId = user?.credentials.find((item) => item.appId == appSlug)?.id;

//Update the default conferencing app for the user.
await prisma.user.update({
Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these prisma calls to a repository (doesn't need to be done in this PR if the repositories would take a lot of work to set up).

emrysal
emrysal approved these changes May 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoped to an app, happy with this - looks good to me

@emrysal emrysal added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 33c1d49 May 28, 2024
@emrysal emrysal deleted the feat/jelly-seamless-signup branch May 28, 2024 18:29
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
@ibex088 @p6l-richard
feat: jelly seamless signup (calcom#15220)
e35350b 
* feat: jelly seamless signup

* fix: wrong import

* add credentialId id to defaultLocation

* add CredentialId and correct appType

* fix: type error
@p6l-richard p6l-richard mentioned this pull request Jul 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithwillcode keithwillcode keithwillcode left review comments

@emrysal emrysal emrysal approved these changes

Assignees

No one assigned

Labels

app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working consumer core area: core, team members only event-types area: event types, event-types ✨ feature New feature or request High priority Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

[CAL-3811] [bug] changing default conferencing app shows 2 empty location Input fields in eventSetup tab [CAL-3803] Jelly seamless signup

3 participants

@ibex088 @emrysal @keithwillcode