test: Delete credential endpoint by joeauyeung · Pull Request #15322 · calcom/cal.diy

joeauyeung · 2024-06-04T14:44:43Z

What does this PR do?

This PR adds tests to the delete credential tRPC endpoint and introduces a MockDatabaseClient class when working with our mock database when testing.

Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected)
I have added a Docs issue here if this PR makes changes that would require a documentation change
I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

github-actions · 2024-06-04T14:44:56Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

graphite-app · 2024-06-04T14:45:10Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (06/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

vercel · 2024-06-04T14:46:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 29, 2024 3:13pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jul 29, 2024 3:13pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Jul 29, 2024 3:13pm

joeauyeung · 2024-06-04T14:46:35Z

  viewer: viewerRouter,
 });

+export const createCaller = tRPCContext.createCallerFactory(appRouter);


This allows us to call tRPC endpoints in tests and server side.
https://trpc.io/docs/server/server-side-calls

joeauyeung · 2024-06-04T14:48:32Z

+  const ctx = await createContextInner({
+    locale: "en",
+    session: {
+      hasValidLicense: true,
+      upId: "test-upId",
+      user: {
+        id: testUser.id,
+        profile: {
+          id: 1,
+          upId: "profile-upid",
+          username: testUser.username,
+        },
+      },
+    },
+  });
+
+  const caller = createCaller(ctx);
+
+  return caller;
+};


Mocks the tRPC context

joeauyeung · 2024-06-04T14:49:24Z

Introduce a MockDatabaseClient for us to easily add data to the mock db while testing.

I like this idea of this but a preferred solution would be to use repositories that can be individually mocked. This file will unfortunately become a huge bucket of mocked database calls that are more fitting to being inside of repositories.

Was the idea that since we don't have repositories in all places yet, this is step 1 of improving the testability?

Ideally, it would be great if we could mock all the database calls in repositories ex. user, event type, etc. There are some resources though that don't have a repository like credentials. If you look at apps\web\test\utils\bookingScenario\bookingScenario.ts a lot of mock db calls are being made in that file. I didn't want to add to that file, so my idea was to create this class as a placeholder for those simpler db calls.

Why don't we add the repositories as we go? i.e. now

keithwillcode · 2024-06-04T15:08:34Z

+    },
+  });
+
+  const caller = createCaller(ctx);


Using tRPC inside of unit tests feels off to me. Would prefer we move towards "thin controllers", in this case "thin handlers", that call off to core application services that handle this logic. tRPC is just the technological mechanism to making an HTTP request so having it in our unit tests that's purpose are to test core logic, not tRPC, is not ideal.

I don't think it's too much of a lift to move basically everything in the handler to a different class/file that is an application service but let me know if there are gotchas.

i.e. We should have a suite of tests that can test our application logic regardless of technology. If we move that tRPC handler to RSC, for instance, now your test breaks and it shouldn't

anikdhabal

LGTM!

* Init * Add mock trpc context * Intro mockDatabaseClient * Introduce mockDatabaseClient class * Add delete video app test * Add calendar test * Remove unused func from bookingScenario * Remove console.log * Add app repository * Add createMany method to event type repository * Remove instance of MockDatabaseClient from video test * Add destination calendar repository * Remove instances of MockDatabaseClient * abstract logic to own handler * Remove dev dependency * Clean up * Type fix * Pull yarn.lock from main --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>

* WIP: Billing service * WIP * Update __handler.ts * Update index.ts * WIP * WIP Signed-off-by: zomars <zomars@me.com> * WIP Signed-off-by: zomars <zomars@me.com> * Update delete.handler.ts * Update delete.handler.ts * Update internal-team-billing.ts * WIP * Type fixes Signed-off-by: zomars <zomars@me.com> * WIP Signed-off-by: zomars <zomars@me.com> * Discard changes to apps/api/v2/src/ee/event-types/event-types_2024_04_15/controllers/event-types.controller.ts * Discard changes to packages/app-store/skype/config.json * style: update text area (#15934) * chore: update text-editor input * chore: update text-editor input * final update * Update Editor.tsx --------- Co-authored-by: unknown <adhabal2002@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> * fix: #15697 Assignment warning modal poping up ,even when hosts are added . (#15699) * removed reduntand check on assignedusers * update for managed eventtype * formatted * comments * Updated comments * extracted checkForEmptyAssignment and added tests * updated comments * updated to show dialog also when not yet saved * update translations * updated comments * updated translation * updated types * chore: update naming and comments * Delete apps/web/lib/checkForEmptyAssignment.ts deleted since file was renamed * Delete apps/web/test/lib/checkForEmptyAssignment.test.ts deleted as the file is renamed to be more descriptive * update to do teamcheck before * chore: revert name to CheckForEmptyAssignment * updated check conditions * updated useEffect dependencies --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> * fix: getting an error when a team member tries to leave (#15925) a team Co-authored-by: Somay Chauhan <somaychauhan98@gmail.com> Co-authored-by: Amit Sharma <74371312+Amit91848@users.noreply.github.com> * feat: add transitions to more components (#15916) * add transitions to more components * chore: Remove duplicate class * fix: Change minimum number of teams required for org self-serve (#15955) * fix: Change minimum number of teams required for org self-serve Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com> * refactor: Use a new constant for displaying org helper text dialogue Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com> * Update packages/lib/constants.ts * Update turbo.json --------- Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> * feat: pwa ready and add shortcut for quick access (#15957) * chore: Update site.webmanifest with additional display properties * chore: Update site.webmanifest with additional display properties * Update apps/web/public/site.webmanifest --------- Co-authored-by: Keith Williams <keithwillcode@gmail.com> * i18n: update translations for "by proceeding, ..." (#15921) * feat: Add title attribute to iframe in embed.ts (#15944) * feat: Add title attribute to iframe in embed.ts * Update packages/embeds/embed-core/src/embed.ts --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * fix: Assignment reminder modal appears when deleting a team event type (#15544) * fix: Assignment reminder modal appears when deleting a team event type * update * Update EventTypeSingleLayout.tsx * Update event-types-single-view.tsx * update * Early return https://handbook.cal.com/engineering/best-practices/prefer-early-returns --------- Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Hariom <hariombalhara@gmail.com> * fix: Add CORP and COEP headers to embedded pages (#15275) * Add CORP headers * Improve test * Add unit tests as well --------- Co-authored-by: Keith Williams <keithwillcode@gmail.com> * feat: No-show bookings - do not count towards a member's round robin assignment (#15323) * feat: No-show bookings - do not count towards a member's round robin assignment * filter no show organizer * remove logs * fix: filter bookings where host attendee is no show * fix: use not condition for noShow * chore: test * add default false for noShowHost * Revert "chore: test" This reverts commit c914a8f. * chore: integration test * fix: noShowHost not working for null * Update packages/lib/server/getLuckyUser.ts * chore: update test description --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: gh0st91848 <gh0st91848@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * refactor: v1 orgs unlimited teams (#15908) * refactor: v1 orgs unlimited teams * fix: response message ownerId --------- Co-authored-by: Keith Williams <keithwillcode@gmail.com> * fix: refresh connect atoms on token change (#15933) * added dropdown * change comment * fix: added types --------- Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> * fix: Next.js bundle analysis (#15903) * fix: Next.js bundle analysis * Added the main checkout back * fix: type in webhook payload (#15912) Co-authored-by: CarinaWolli <wollencarina@gmail.com> * fix: auto accept (#15975) * fix: auto accept * Update packages/lib/server/repository/organization.ts Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> * fix: Broken GitHub workflows (#15979) * test: Delete credential endpoint (#15322) * Init * Add mock trpc context * Intro mockDatabaseClient * Introduce mockDatabaseClient class * Add delete video app test * Add calendar test * Remove unused func from bookingScenario * Remove console.log * Add app repository * Add createMany method to event type repository * Remove instance of MockDatabaseClient from video test * Add destination calendar repository * Remove instances of MockDatabaseClient * abstract logic to own handler * Remove dev dependency * Clean up * Type fix * Pull yarn.lock from main --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> * fix: #15967 Show better error when wrong variable is used in custom event name (#15974) * update to show exact err msg with custom event name * updated tests for validateCustomEventName --------- Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> * WIP Signed-off-by: zomars <zomars@me.com> * Update yarn.lock * Update publish.handler.ts * Update internal-team-billing.test.ts * rename create to init * remove sync services * wip tests for delete team * wip tets * wip tests * tests/internal-test * remove return that is inaccessable * remove team calls to use repository * remove redudant file * update team repo * add stripe mocks and test * fix constants * tests to main stripe handler * remove logs * fix constants * Update packages/features/ee/billing/api/webhook/_customer.subscription.deleted.team-plan.ts Co-authored-by: Omar López <zomars@me.com> * move workflow logic to a service * use static method > creating new class * fix: remove http code deep in repo + tests * Feedback * Update index.ts * Type fix * Lazy load fixes --------- Signed-off-by: zomars <zomars@me.com> Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com> Co-authored-by: Rohan Advani <122167726+RNAdvani@users.noreply.github.com> Co-authored-by: unknown <adhabal2002@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Vijay <vijayraghav22@gmail.com> Co-authored-by: Somay Chauhan <somaychauhan98@gmail.com> Co-authored-by: Amit Sharma <74371312+Amit91848@users.noreply.github.com> Co-authored-by: Hichem Fantar <hichemfantar2049@gmail.com> Co-authored-by: Souptik Datta <souptikdatta2001@gmail.com> Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Johannes Maendle <141119154+jomaendle2@users.noreply.github.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: gh0st91848 <gh0st91848@gmail.com> Co-authored-by: Lauris Skraucis <lauris.skraucis@gmail.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com> Co-authored-by: sean-brydon <sean@cal.com> Co-authored-by: sean <sean@brydon.io>

joeauyeung added 6 commits May 31, 2024 14:09

Init

c8da315

Add mock trpc context

a8e72cf

Intro mockDatabaseClient

0378e20

Introduce mockDatabaseClient class

268a167

Add delete video app test

e44633a

Add calendar test

e94a2c6

graphite-app bot requested review from a team June 4, 2024 14:44

keithwillcode added consumer core area: core, team members only labels Jun 4, 2024

dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Jun 4, 2024

Remove unused func from bookingScenario

0e7efce

Merge branch 'main' into trpc-tests

a773797

joeauyeung commented Jun 4, 2024

View reviewed changes

joeauyeung changed the title ~~tests: Delete credential endpoint~~ test: Delete credential endpoint Jun 4, 2024

vercel bot deployed to Preview – ai June 4, 2024 14:50 View deployment

vercel bot deployed to Preview – api June 4, 2024 14:56 View deployment

keithwillcode reviewed Jun 4, 2024

View reviewed changes

vercel bot deployed to Preview – dev June 4, 2024 15:12 View deployment

Remove console.log

39fe7eb

vercel bot deployed to Preview – api June 4, 2024 15:26 View deployment

vercel bot deployed to Preview – dev June 4, 2024 15:42 View deployment

joeauyeung added 3 commits June 4, 2024 12:17

Add app repository

e3daffb

Add createMany method to event type repository

47dbbaa

Remove instance of MockDatabaseClient from video test

721d389

vercel bot deployed to Preview – ai June 4, 2024 19:35 View deployment

vercel bot deployed to Preview – api June 4, 2024 19:38 View deployment

vercel bot had a problem deploying to Preview – api July 16, 2024 14:14 Failure

vercel bot deployed to Preview – ai July 16, 2024 14:15 View deployment

vercel bot deployed to Preview – dev July 16, 2024 14:43 View deployment

Type fix

5b5eca1

vercel bot deployed to Preview – api July 16, 2024 14:54 View deployment

Merge branch 'main' into trpc-tests

309608d

vercel bot had a problem deploying to Preview – ai July 16, 2024 15:00 Failure

vercel bot deployed to Preview – api July 16, 2024 15:06 View deployment

vercel bot deployed to Preview – dev July 16, 2024 15:24 View deployment

Merge branch 'main' into trpc-tests

e292738

vercel bot had a problem deploying to Preview – ai July 16, 2024 17:35 Failure

vercel bot deployed to Preview – api July 16, 2024 17:42 View deployment

vercel bot deployed to Preview – dev July 16, 2024 17:54 View deployment

github-actions bot removed the Stale label Jul 17, 2024

joeauyeung and others added 2 commits July 29, 2024 09:18

Pull yarn.lock from main

4dba995

Merge branch 'main' into trpc-tests

5eeaccc

vercel bot deployed to Preview – ai July 29, 2024 13:21 View deployment

vercel bot deployed to Preview – api July 29, 2024 13:31 View deployment

vercel bot deployed to Preview – dev July 29, 2024 13:39 View deployment

anikdhabal approved these changes Jul 29, 2024

View reviewed changes

github-actions bot added the ready-for-e2e label Jul 29, 2024

Merge branch 'main' into trpc-tests

ae9966c

vercel bot deployed to Preview – ai July 29, 2024 15:13 View deployment

vercel bot deployed to Preview – api July 29, 2024 15:17 View deployment

vercel bot deployed to Preview – dev July 29, 2024 15:37 View deployment

joeauyeung merged commit 9a1a86e into main Jul 29, 2024

joeauyeung deleted the trpc-tests branch July 29, 2024 15:39

joeauyeung mentioned this pull request Aug 29, 2024

refactor: Billing service #15366

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Delete credential endpoint#15322

test: Delete credential endpoint#15322
joeauyeung merged 25 commits intomainfrom
trpc-tests

joeauyeung commented Jun 4, 2024

Uh oh!

github-actions bot commented Jun 4, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 4, 2024

Uh oh!

vercel bot commented Jun 4, 2024 •

edited

Loading

Uh oh!

joeauyeung Jun 4, 2024

Uh oh!

joeauyeung Jun 4, 2024

Uh oh!

joeauyeung Jun 4, 2024

Uh oh!

keithwillcode Jun 4, 2024

Uh oh!

joeauyeung Jun 4, 2024 •

edited

Loading

Uh oh!

keithwillcode Jun 4, 2024

Uh oh!

keithwillcode Jun 4, 2024 •

edited

Loading

Uh oh!

keithwillcode Jun 4, 2024

Uh oh!

anikdhabal left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

joeauyeung commented Jun 4, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Uh oh!

github-actions bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jun 4, 2024

Graphite Automations

Uh oh!

vercel bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joeauyeung Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

joeauyeung Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

joeauyeung Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

keithwillcode Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

joeauyeung Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keithwillcode Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

keithwillcode Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keithwillcode Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

anikdhabal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Jun 4, 2024 •

edited

Loading

vercel bot commented Jun 4, 2024 •

edited

Loading

joeauyeung Jun 4, 2024 •

edited

Loading

keithwillcode Jun 4, 2024 •

edited

Loading