Skip to content

chore: Delete unused module#15631

Merged
hariombalhara merged 4 commits intocalcom:mainfrom
RushikeshGandhmal:rushikesh_use_correct_object_keys
Jul 1, 2024
Merged

chore: Delete unused module#15631
hariombalhara merged 4 commits intocalcom:mainfrom
RushikeshGandhmal:rushikesh_use_correct_object_keys

Conversation

@RushikeshGandhmal
Copy link
Copy Markdown
Contributor

@RushikeshGandhmal RushikeshGandhmal commented Jun 30, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 30, 2024

@RushikeshGandhmal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Jun 30, 2024
@graphite-app graphite-app Bot requested a review from a team June 30, 2024 16:49
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 30, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added the 🐛 bug Something isn't working label Jun 30, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jun 30, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/30/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@dosubot dosubot Bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar 💻 refactor labels Jun 30, 2024
@RushikeshGandhmal RushikeshGandhmal changed the title refactor: use correct object keys fix: use correct object keys Jun 30, 2024
@hariombalhara
Copy link
Copy Markdown
Member

hariombalhara commented Jul 1, 2024

Thanks for the PR @RushikeshGandhmal 🙏 But I just discovered while testing that this component isn't being used, could you confirm and just delete this file.

We actually have an AppDependencyComponent that replaces this and is reusable across all apps that need it.

hariombalhara
hariombalhara requested changes Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment.

@RushikeshGandhmal RushikeshGandhmal force-pushed the rushikesh_use_correct_object_keys branch from 583f930 to 3e3ad76 Compare July 1, 2024 08:23
@RushikeshGandhmal
Copy link
Copy Markdown
Contributor Author

RushikeshGandhmal commented Jul 1, 2024

Welcome, @hariombalhara. Yes, I confirmed that ExistingGoogleCal component is not being used so I removed.

rushikesh

hariombalhara
hariombalhara approved these changes Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hariombalhara hariombalhara enabled auto-merge (squash) July 1, 2024 08:44
@hariombalhara hariombalhara changed the title fix: use correct object keys chore: Delete unused module Jul 1, 2024
@hariombalhara
Copy link
Copy Markdown
Member

hariombalhara commented Jul 1, 2024

@RushikeshGandhmal I think you have not signed CLA. That's required to merge the PR.

@RushikeshGandhmal
Copy link
Copy Markdown
Contributor Author

RushikeshGandhmal commented Jul 1, 2024

@hariombalhara previously my PR's got merged. you can check: #15463

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seventy-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 286.64 KB 514.32 KB 146.95% (🟡 +0.70%)
/apps/[slug] 304.22 KB 531.91 KB 151.97% (🟡 +0.70%)
/apps/[slug]/[...pages] 595.02 KB 822.71 KB 235.06% (🟡 +0.68%)
/apps/categories 262.99 KB 490.68 KB 140.19% (🟡 +0.70%)
/apps/categories/[category] 268.74 KB 496.43 KB 141.84% (🟡 +0.70%)
/apps/installed/[category] 285.09 KB 512.78 KB 146.51% (🟡 +0.14%)
/auth/saml-idp 12.22 KB 239.91 KB 68.55% (🟢 -20.80%)
/availability/[schedule] 417.04 KB 644.73 KB 184.21% (🟡 +0.21%)
/bookings/[status] 332.67 KB 560.36 KB 160.10% (🟡 +0.71%)
/enterprise 263.04 KB 490.73 KB 140.21% (🟡 +0.70%)
/event-types 568.05 KB 795.74 KB 227.35% (🟡 +0.77%)
/event-types/[type] 443.71 KB 671.4 KB 191.83% (🟡 +0.62%)
/insights 481.4 KB 709.09 KB 202.60% (🟡 +0.24%)
/more 262.55 KB 490.24 KB 140.07% (🟡 +0.70%)
/settings/admin 268.94 KB 496.63 KB 141.89% (🟡 +0.70%)
/settings/admin/apps 282.18 KB 509.87 KB 145.68% (🟡 +0.67%)
/settings/admin/apps/[category] 282.17 KB 509.85 KB 145.67% (🟡 +0.67%)
/settings/admin/flags 272.66 KB 500.35 KB 142.96% (🟡 +0.67%)
/settings/admin/impersonation 269.33 KB 497.02 KB 142.01% (🟡 +0.70%)
/settings/admin/lockedSMS 290.37 KB 518.06 KB 148.02% (🟡 +0.71%)
/settings/admin/lockedSMS/UsersTable 79.98 KB 307.67 KB 87.90% (🟢 -0.14%)
/settings/admin/lockedSMS/lockedSMSView 119.46 KB 347.15 KB 99.19% (🟢 -0.17%)
/settings/admin/oAuth 280.91 KB 508.6 KB 145.31% (🟡 +0.67%)
/settings/admin/oAuth/oAuthView 95.5 KB 323.19 KB 92.34% (🟢 -0.18%)
/settings/admin/orgMigrations/_OrgMigrationLayout 257.73 KB 485.41 KB 138.69% (🟡 +0.66%)
/settings/admin/orgMigrations/moveTeamToOrg 307.61 KB 535.29 KB 152.94% (🟡 +0.71%)
/settings/admin/orgMigrations/moveUserToOrg 327.38 KB 555.07 KB 158.59% (🟡 +0.73%)
/settings/admin/orgMigrations/removeTeamFromOrg 307.37 KB 535.06 KB 152.87% (🟡 +0.72%)
/settings/admin/orgMigrations/removeUserFromOrg 307.38 KB 535.07 KB 152.88% (🟡 +0.71%)
/settings/admin/organizations 270.83 KB 498.51 KB 142.43% (🟡 +0.70%)
/settings/admin/organizations/[id]/edit 269.49 KB 497.18 KB 142.05% (🟡 +0.70%)
/settings/admin/users 271.6 KB 499.28 KB 142.65% (🟡 +0.70%)
/settings/admin/users/[id]/edit 400.63 KB 628.32 KB 179.52% (🟡 +0.69%)
/settings/admin/users/add 400.29 KB 627.98 KB 179.42% (🟡 +0.69%)
/settings/billing 269.15 KB 496.83 KB 141.95% (🟡 +0.70%)
/settings/developer/api-keys 273.43 KB 501.12 KB 143.18% (🟡 +0.67%)
/settings/developer/webhooks 273.6 KB 501.29 KB 143.23% (🟡 +0.66%)
/settings/developer/webhooks/[id] 274.55 KB 502.24 KB 143.50% (🟡 +0.67%)
/settings/developer/webhooks/new 274.58 KB 502.27 KB 143.50% (🟡 +0.68%)
/settings/my-account/appearance 321.05 KB 548.74 KB 156.78% (🟡 +0.40%)
/settings/my-account/calendars 281.06 KB 508.75 KB 145.36% (🟡 +0.80%)
/settings/my-account/general 384.55 KB 612.24 KB 174.92% (🟡 +0.68%)
/settings/my-account/out-of-office 274.07 KB 501.76 KB 143.36% (🟡 +0.67%)
/settings/my-account/profile 416.53 KB 644.21 KB 184.06% (🟡 +0.55%)
/settings/organizations/[id]/about 159.67 KB 387.35 KB 110.67% (🟡 +0.48%)
/settings/organizations/[id]/add-teams 159.66 KB 387.35 KB 110.67% (🟡 +0.47%)
/settings/organizations/admin-api 269.1 KB 496.79 KB 141.94% (🟡 +0.70%)
/settings/organizations/appearance 292.76 KB 520.45 KB 148.70% (🟡 +0.67%)
/settings/organizations/billing 269.18 KB 496.87 KB 141.96% (🟡 +0.70%)
/settings/organizations/dsync 301.81 KB 529.49 KB 151.28% (🟡 +0.70%)
/settings/organizations/general 357.39 KB 585.08 KB 167.17% (🟡 +0.67%)
/settings/organizations/members 406.9 KB 634.58 KB 181.31% (🟡 +0.21%)
/settings/organizations/new 159.67 KB 387.36 KB 110.67% (🟡 +0.48%)
/settings/organizations/privacy 274.59 KB 502.28 KB 143.51% (🟡 +0.67%)
/settings/organizations/profile 409.25 KB 636.94 KB 181.98% (🟡 +0.61%)
/settings/organizations/sso 279.77 KB 507.46 KB 144.99% (🟡 +0.70%)
/settings/organizations/teams/other 270.01 KB 497.7 KB 142.20% (🟡 +0.70%)
/settings/organizations/teams/other/[id]/appearance 281.64 KB 509.33 KB 145.52% (🟡 +0.67%)
/settings/organizations/teams/other/[id]/members 276.5 KB 504.19 KB 144.05% (🟡 +0.67%)
/settings/organizations/teams/other/[id]/profile 480.16 KB 707.85 KB 202.24% (🟡 +0.66%)
/settings/platform 267.65 KB 495.34 KB 141.53% (🟡 +0.69%)
/settings/platform/new 120.72 KB 348.4 KB 99.54% (🟡 +0.52%)
/settings/platform/oauth-clients/[clientId]/edit 265.96 KB 493.65 KB 141.04% (🟡 +0.70%)
/settings/platform/oauth-clients/create 265.1 KB 492.79 KB 140.80% (🟡 +0.70%)
/settings/security/impersonation 274.25 KB 501.93 KB 143.41% (🟡 +0.67%)
/settings/security/password 312.4 KB 540.09 KB 154.31% (🟡 +0.69%)
/settings/security/sso 279.22 KB 506.91 KB 144.83% (🟡 +0.70%)
/settings/security/two-factor-auth 277.73 KB 505.42 KB 144.41% (🟡 +0.67%)
/settings/teams 268.68 KB 496.37 KB 141.82% (🟡 +0.70%)
/settings/teams/[id]/appearance 281.62 KB 509.31 KB 145.52% (🟡 +0.67%)
/settings/teams/[id]/billing 269.18 KB 496.87 KB 141.96% (🟡 +0.70%)
/settings/teams/[id]/members 386.62 KB 614.31 KB 175.52% (🟡 +0.67%)
/settings/teams/[id]/profile 480.99 KB 708.68 KB 202.48% (🟡 +0.67%)
/teams 262.78 KB 490.47 KB 140.13% (🟡 +0.70%)
/upgrade 262.9 KB 490.59 KB 140.17% (🟡 +0.70%)
/video/[uid] 291.22 KB 518.91 KB 148.26% (🟢 -0.17%)
/workflows 294.65 KB 522.34 KB 149.24% (🟡 +0.71%)
/workflows/[workflow] 420.57 KB 648.26 KB 185.22% (🟡 +0.26%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@hariombalhara hariombalhara merged commit b43aaac into calcom:main Jul 1, 2024
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
@RushikeshGandhmal @p6l-richard
fix: use correct object keys (calcom#15631)
589d9bf 
* use connected_google_calendar translation key

* use requires_google_calendar translation key

* Remove unused ExistingGoogleCal component
@p6l-richard p6l-richard mentioned this pull request Jul 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

Assignees

No one assigned

Labels

🐛 bug Something isn't working calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync ready-for-e2e 💻 refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use Correct Object Keys

4 participants

@RushikeshGandhmal @CLAassistant @hariombalhara @keithwillcode