Skip to content

fix: datePicker skeleton issue solved#15675

Merged
Udit-takkar merged 3 commits intocalcom:mainfrom
raza001:main
Jul 8, 2024
Merged

fix: datePicker skeleton issue solved#15675
Udit-takkar merged 3 commits intocalcom:mainfrom
raza001:main

Conversation

@raza001
Copy link
Copy Markdown
Contributor

@raza001 raza001 commented Jul 6, 2024

Demo Video
https://www.loom.com/share/531746192b0941d9bdcca36f0231b501

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Jul 6, 2024
@graphite-app graphite-app Bot requested a review from a team July 6, 2024 07:16
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 6, 2024

@raza001 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 6, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "datePicker skeleton issue solved". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot Bot added core area: core, team members only ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Jul 6, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jul 6, 2024

Graphite Automations

"Add community label" took an action on this PR • (07/06/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (07/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal changed the title datePicker skeleton issue solved fix: datePicker skeleton issue solved Jul 6, 2024
@anikdhabal anikdhabal removed the core area: core, team members only label Jul 6, 2024
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 6, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seventy-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 279.89 KB 507.56 KB 145.02% (🟢 -1.23%)
/apps/[slug] 297.48 KB 525.15 KB 150.04% (🟢 -1.22%)
/apps/[slug]/[...pages] 588.54 KB 816.21 KB 233.20% (🟢 -1.17%)
/apps/categories 256.24 KB 483.92 KB 138.26% (🟢 -1.23%)
/apps/categories/[category] 262 KB 489.67 KB 139.91% (🟢 -1.23%)
/apps/installed/[category] 278.34 KB 506.02 KB 144.58% (🟢 -1.79%)
/auth/saml-idp 12.22 KB 239.9 KB 68.54% (🟢 -20.80%)
/availability 426.14 KB 653.82 KB 186.80% (🟢 -1.79%)
/availability/[schedule] 410.56 KB 638.24 KB 182.35% (🟢 -1.64%)
/bookings/[status] 325.93 KB 553.6 KB 158.17% (🟢 -1.22%)
/enterprise 256.3 KB 483.97 KB 138.28% (🟢 -1.23%)
/event-types 561.25 KB 788.92 KB 225.41% (🟢 -1.18%)
/event-types/[type] 437.45 KB 665.12 KB 190.04% (🟢 -1.17%)
/insights 474.66 KB 702.33 KB 200.67% (🟢 -1.69%)
/more 255.81 KB 483.48 KB 138.14% (🟢 -1.23%)
/settings/admin 262.24 KB 489.92 KB 139.98% (🟢 -1.22%)
/settings/admin/apps 275.48 KB 503.16 KB 143.76% (🟢 -1.24%)
/settings/admin/apps/[category] 275.47 KB 503.14 KB 143.76% (🟢 -1.25%)
/settings/admin/flags 265.96 KB 493.64 KB 141.04% (🟢 -1.25%)
/settings/admin/impersonation 262.63 KB 490.31 KB 140.09% (🟢 -1.22%)
/settings/admin/lockedSMS 283.69 KB 511.37 KB 146.11% (🟢 -1.20%)
/settings/admin/oAuth 274.24 KB 501.91 KB 143.40% (🟢 -1.24%)
/settings/admin/orgMigrations/_OrgMigrationLayout 251.17 KB 478.84 KB 136.81% (🟢 -1.21%)
/settings/admin/orgMigrations/moveTeamToOrg 300.91 KB 528.58 KB 151.02% (🟢 -1.20%)
/settings/admin/orgMigrations/moveUserToOrg 320.7 KB 548.38 KB 156.68% (🟢 -1.18%)
/settings/admin/orgMigrations/removeTeamFromOrg 300.67 KB 528.35 KB 150.96% (🟢 -1.20%)
/settings/admin/orgMigrations/removeUserFromOrg 300.68 KB 528.36 KB 150.96% (🟢 -1.20%)
/settings/admin/organizations 264.13 KB 491.8 KB 140.51% (🟢 -1.21%)
/settings/admin/organizations/[id]/edit 262.79 KB 490.46 KB 140.13% (🟢 -1.21%)
/settings/admin/users 264.9 KB 492.57 KB 140.74% (🟢 -1.22%)
/settings/admin/users/[id]/edit 393.96 KB 621.63 KB 177.61% (🟢 -1.22%)
/settings/admin/users/add 393.63 KB 621.3 KB 177.51% (🟢 -1.21%)
/settings/billing 262.45 KB 490.12 KB 140.03% (🟢 -1.21%)
/settings/developer/api-keys 266.73 KB 494.41 KB 141.26% (🟢 -1.25%)
/settings/developer/webhooks 266.9 KB 494.58 KB 141.31% (🟢 -1.25%)
/settings/developer/webhooks/[id] 267.89 KB 495.56 KB 141.59% (🟢 -1.23%)
/settings/developer/webhooks/new 267.92 KB 495.59 KB 141.60% (🟢 -1.23%)
/settings/my-account/appearance 314.33 KB 542 KB 154.86% (🟢 -1.53%)
/settings/my-account/calendars 274.36 KB 502.04 KB 143.44% (🟢 -1.11%)
/settings/my-account/conferencing 272.34 KB 500.01 KB 142.86% (🟢 -1.94%)
/settings/my-account/general 377.85 KB 605.52 KB 173.01% (🟢 -1.24%)
/settings/my-account/out-of-office 267.37 KB 495.04 KB 141.44% (🟢 -1.24%)
/settings/my-account/profile 410.3 KB 637.97 KB 182.28% (🟢 -1.24%)
/settings/organizations/[id]/about 159.67 KB 387.35 KB 110.67% (🟡 +0.48%)
/settings/organizations/[id]/add-teams 159.67 KB 387.34 KB 110.67% (🟡 +0.47%)
/settings/organizations/admin-api 262.4 KB 490.08 KB 140.02% (🟢 -1.21%)
/settings/organizations/appearance 122.33 KB 350.01 KB 100.00% (🟢 -48.02%)
/settings/organizations/billing 262.48 KB 490.16 KB 140.04% (🟢 -1.21%)
/settings/organizations/dsync 295.11 KB 522.78 KB 149.37% (🟢 -1.22%)
/settings/organizations/general 350.69 KB 578.37 KB 165.25% (🟢 -1.24%)
/settings/organizations/members 400.51 KB 628.18 KB 179.48% (🟢 -1.62%)
/settings/organizations/new 159.68 KB 387.35 KB 110.67% (🟡 +0.48%)
/settings/organizations/privacy 267.89 KB 495.57 KB 141.59% (🟢 -1.24%)
/settings/organizations/profile 415.16 KB 642.83 KB 183.67% (🟡 +2.29%)
/settings/organizations/sso 273.07 KB 500.75 KB 143.07% (🟢 -1.21%)
/settings/organizations/teams/other 263.31 KB 490.99 KB 140.28% (🟢 -1.21%)
/settings/organizations/teams/other/[id]/appearance 275.12 KB 502.79 KB 143.65% (🟢 -1.19%)
/settings/organizations/teams/other/[id]/members 269.8 KB 497.48 KB 142.14% (🟢 -1.25%)
/settings/organizations/teams/other/[id]/profile 473.52 KB 701.19 KB 200.34% (🟢 -1.24%)
/settings/platform 260.91 KB 488.58 KB 139.59% (🟢 -1.22%)
/settings/platform/new 120.69 KB 348.36 KB 99.53% (🟡 +0.51%)
/settings/platform/oauth-clients/[clientId]/edit 259.21 KB 486.89 KB 139.11% (🟢 -1.23%)
/settings/platform/oauth-clients/create 258.35 KB 486.03 KB 138.86% (🟢 -1.22%)
/settings/security/impersonation 267.55 KB 495.22 KB 141.49% (🟢 -1.24%)
/settings/security/password 305.7 KB 533.38 KB 152.39% (🟢 -1.23%)
/settings/security/sso 272.52 KB 500.2 KB 142.91% (🟢 -1.21%)
/settings/security/two-factor-auth 271.03 KB 498.71 KB 142.49% (🟢 -1.25%)
/settings/teams 261.98 KB 489.65 KB 139.90% (🟢 -1.21%)
/settings/teams/[id]/appearance 275.1 KB 502.77 KB 143.65% (🟢 -1.19%)
/settings/teams/[id]/billing 262.49 KB 490.16 KB 140.05% (🟢 -1.22%)
/settings/teams/[id]/members 379.92 KB 607.6 KB 173.60% (🟢 -1.24%)
/settings/teams/[id]/profile 474.3 KB 701.98 KB 200.57% (🟢 -1.24%)
/settings/teams/new 193.08 KB 420.75 KB 120.22% (🟢 -1.81%)
/teams 256.03 KB 483.71 KB 138.20% (🟢 -1.23%)
/upgrade 256.15 KB 483.83 KB 138.24% (🟢 -1.23%)
/video/[uid] 291.18 KB 518.85 KB 148.24% (🟢 -0.18%)
/workflows 287.93 KB 515.6 KB 147.31% (🟢 -1.20%)
/workflows/[workflow] 413.85 KB 641.52 KB 183.29% (🟢 -1.66%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@Udit-takkar Udit-takkar merged commit 8b5ef68 into calcom:main Jul 8, 2024
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
* datePicker skeleton issue solved

* Update

---------

Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not enough contrast for spinner while waiting for times to show up

3 participants