Skip to content

chore: Add v2 API test suite#15865

Merged
keithwillcode merged 7 commits intomainfrom
chore/add-v2-tests-simplified
Jul 24, 2024
Merged

chore: Add v2 API test suite#15865
keithwillcode merged 7 commits intomainfrom
chore/add-v2-tests-simplified

Conversation

@keithwillcode
Copy link
Copy Markdown
Contributor

@keithwillcode keithwillcode commented Jul 22, 2024

What does this PR do?

Adds the test suites (e2e and unit) for API v2 to our CI pipeline.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Verify that all of the new tests added pass here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 7:46am
cal ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 7:46am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 7:46am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 23, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 277.5 KB 505.16 KB 144.33% (🟢 -1.91%)
/apps/[slug] 294.88 KB 522.54 KB 149.30% (🟢 -1.97%)
/apps/[slug]/[...pages] 587.32 KB 814.97 KB 232.85% (🟢 -1.52%)
/apps/categories 254.55 KB 482.21 KB 137.77% (🟢 -1.71%)
/apps/categories/[category] 259.36 KB 487.01 KB 139.15% (🟢 -1.99%)
/apps/installation/[[...step]] 467.39 KB 695.05 KB 198.59% (🔴 +85.63%)
/apps/installed/[category] 278.5 KB 506.15 KB 144.61% (🟢 -1.74%)
/auth/saml-idp 12.22 KB 239.88 KB 68.54% (🟢 -20.80%)
/availability 426.9 KB 654.56 KB 187.02% (🟢 -1.58%)
/availability/[schedule] 410.77 KB 638.43 KB 182.41% (🟢 -1.59%)
/booking/[uid] 236.87 KB 464.52 KB 132.72% (🟡 +0.26%)
/booking/[uid]/embed 236.87 KB 464.53 KB 132.72% (🟡 +0.26%)
/bookings/[status] 324.57 KB 552.23 KB 157.78% (🟢 -1.61%)
/enterprise 254.6 KB 482.26 KB 137.79% (🟢 -1.71%)
/event-types 559.92 KB 787.58 KB 225.02% (🟢 -1.55%)
/event-types/[type] 435.69 KB 663.35 KB 189.53% (🟢 -1.67%)
/getting-started/[[...step]] 448.15 KB 675.8 KB 193.09% (🟡 +10.72%)
/insights 474.55 KB 702.2 KB 200.63% (🟢 -1.71%)
/more 254.11 KB 481.77 KB 137.65% (🟢 -1.72%)
/payment/[uid] 121.27 KB 348.93 KB 99.69% (🟡 +0.20%)
/settings/admin 260.58 KB 488.24 KB 139.50% (🟢 -1.69%)
/settings/admin/apps 273.96 KB 501.62 KB 143.32% (🟢 -1.68%)
/settings/admin/apps/[category] 273.95 KB 501.6 KB 143.32% (🟢 -1.68%)
/settings/admin/flags 264.41 KB 492.07 KB 140.59% (🟢 -1.69%)
/settings/admin/impersonation 260.97 KB 488.63 KB 139.61% (🟢 -1.69%)
/settings/admin/lockedSMS 282.07 KB 509.72 KB 145.63% (🟢 -1.66%)
/settings/admin/lockedSMS/lockedSMSView 119.52 KB 347.17 KB 99.19% (🟢 -0.15%)
/settings/admin/oAuth 272.69 KB 500.35 KB 142.96% (🟢 -1.69%)
/settings/admin/oAuth/oAuthView 95.41 KB 323.07 KB 92.30% (🟢 -0.20%)
/settings/admin/orgMigrations/_OrgMigrationLayout 249.36 KB 477.02 KB 136.29% (🟢 -1.73%)
/settings/admin/orgMigrations/moveTeamToOrg 299.28 KB 526.94 KB 150.55% (🟢 -1.66%)
/settings/admin/orgMigrations/moveUserToOrg 319.11 KB 546.77 KB 156.22% (🟢 -1.64%)
/settings/admin/orgMigrations/removeTeamFromOrg 299.05 KB 526.7 KB 150.49% (🟢 -1.67%)
/settings/admin/orgMigrations/removeUserFromOrg 299.06 KB 526.71 KB 150.49% (🟢 -1.66%)
/settings/admin/organizations 262.47 KB 490.12 KB 140.03% (🟢 -1.68%)
/settings/admin/organizations/[id]/edit 261.13 KB 488.78 KB 139.65% (🟢 -1.69%)
/settings/admin/users 263.24 KB 490.89 KB 140.26% (🟢 -1.69%)
/settings/admin/users/[id]/edit 392.44 KB 620.1 KB 177.17% (🟢 -1.65%)
/settings/admin/users/add 392.11 KB 619.77 KB 177.08% (🟢 -1.66%)
/settings/billing 260.79 KB 488.44 KB 139.55% (🟢 -1.68%)
/settings/developer/api-keys 265.18 KB 492.84 KB 140.81% (🟢 -1.69%)
/settings/developer/webhooks 265.36 KB 493.01 KB 140.86% (🟢 -1.69%)
/settings/developer/webhooks/[id] 266.34 KB 493.99 KB 141.14% (🟢 -1.67%)
/settings/developer/webhooks/new 266.36 KB 494.02 KB 141.15% (🟢 -1.67%)
/settings/my-account/appearance 313.8 KB 541.46 KB 154.70% (🟢 -1.68%)
/settings/my-account/calendars 272.21 KB 499.86 KB 142.82% (🟢 -1.73%)
/settings/my-account/conferencing 273.12 KB 500.78 KB 143.08% (🟢 -1.72%)
/settings/my-account/general 376.29 KB 603.95 KB 172.56% (🟢 -1.68%)
/settings/my-account/out-of-office 265.82 KB 493.47 KB 140.99% (🟢 -1.69%)
/settings/my-account/profile 408.81 KB 636.47 KB 181.85% (🟢 -1.66%)
/settings/organizations/[id]/about 159.7 KB 387.36 KB 110.67% (🟡 +0.49%)
/settings/organizations/[id]/add-teams 159.7 KB 387.35 KB 110.67% (🟡 +0.49%)
/settings/organizations/admin-api 260.74 KB 488.39 KB 139.54% (🟢 -1.69%)
/settings/organizations/appearance 122.37 KB 350.03 KB 100.01% (🟢 -48.01%)
/settings/organizations/billing 260.82 KB 488.48 KB 139.57% (🟢 -1.69%)
/settings/organizations/dsync 293.44 KB 521.1 KB 148.89% (🟢 -1.69%)
/settings/organizations/general 349.13 KB 576.79 KB 164.80% (🟢 -1.69%)
/settings/organizations/members 400.3 KB 627.96 KB 179.42% (🟢 -1.68%)
/settings/organizations/new 159.71 KB 387.36 KB 110.68% (🟡 +0.48%)
/settings/organizations/privacy 266.34 KB 493.99 KB 141.14% (🟢 -1.69%)
/settings/organizations/profile 417.35 KB 645 KB 184.29% (🟡 +2.92%)
/settings/organizations/sso 271.41 KB 499.07 KB 142.59% (🟢 -1.69%)
/settings/organizations/teams/other 261.65 KB 489.31 KB 139.80% (🟢 -1.69%)
/settings/organizations/teams/other/[id]/appearance 273.56 KB 501.21 KB 143.20% (🟢 -1.63%)
/settings/organizations/teams/other/[id]/members 268.25 KB 495.91 KB 141.69% (🟢 -1.69%)
/settings/organizations/teams/other/[id]/profile 472.03 KB 699.68 KB 199.91% (🟢 -1.67%)
/settings/platform 259.21 KB 486.87 KB 139.10% (🟢 -1.71%)
/settings/platform/new 120.72 KB 348.37 KB 99.53% (🟡 +0.52%)
/settings/platform/oauth-clients/[clientId]/edit 257.52 KB 485.17 KB 138.62% (🟢 -1.71%)
/settings/platform/oauth-clients/create 256.66 KB 484.31 KB 138.38% (🟢 -1.72%)
/settings/security/impersonation 265.99 KB 493.65 KB 141.04% (🟢 -1.69%)
/settings/security/password 304.18 KB 531.83 KB 151.95% (🟢 -1.66%)
/settings/security/sso 270.86 KB 498.52 KB 142.43% (🟢 -1.69%)
/settings/security/two-factor-auth 269.47 KB 497.13 KB 142.04% (🟢 -1.69%)
/settings/teams 260.32 KB 487.97 KB 139.42% (🟢 -1.69%)
/settings/teams/[id]/appearance 273.54 KB 501.2 KB 143.20% (🟢 -1.64%)
/settings/teams/[id]/billing 260.82 KB 488.48 KB 139.57% (🟢 -1.69%)
/settings/teams/[id]/members 378.37 KB 606.03 KB 173.15% (🟢 -1.68%)
/settings/teams/[id]/profile 472.86 KB 700.51 KB 200.15% (🟢 -1.66%)
/settings/teams/new 193.05 KB 420.71 KB 120.20% (🟢 -1.81%)
/teams 254.34 KB 481.99 KB 137.71% (🟢 -1.71%)
/upgrade 254.46 KB 482.12 KB 137.75% (🟢 -1.71%)
/video/[uid] 291.31 KB 518.97 KB 148.28% (🟢 -0.15%)
/workflows 286.36 KB 514.02 KB 146.86% (🟢 -1.65%)
/workflows/[workflow] 414.66 KB 642.31 KB 183.52% (🟢 -1.43%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@keithwillcode keithwillcode requested a review from a team July 24, 2024 07:43
@keithwillcode keithwillcode added this to the v4.4 milestone Jul 24, 2024
@keithwillcode keithwillcode added the Medium priority Created by Linear-GitHub Sync label Jul 24, 2024
@keithwillcode keithwillcode marked this pull request as ready for review July 24, 2024 07:43
@graphite-app graphite-app Bot requested a review from a team July 24, 2024 07:43
@dosubot dosubot Bot added api area: API, enterprise API, access token, OAuth automated-tests area: unit tests, e2e tests, playwright ci area: CI, DX, pipeline, github actions labels Jul 24, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jul 24, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (07/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@socket-security
Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@calcom/platform-libraries@0.0.2 environment, network, unsafe 0 3.55 MB morgan-calcom
npm/@calcom/platform-libraries@0.0.20 environment, network, unsafe 0 3.66 MB lauris-cal
npm/@golevelup/ts-jest@0.4.0 None 0 20.1 kB wonderpanda
npm/@langchain/core@0.1.63 Transitive: environment, filesystem, network, shell +28 29.1 MB jacoblee93
npm/@langchain/openai@0.0.14 None +13 26.2 MB jacoblee93
npm/@microsoft/microsoft-graph-types-beta@0.42.0-preview None 0 3.41 MB microsoftgraph
npm/@nestjs/cli@10.4.2 Transitive: environment, eval, filesystem, network, shell, unsafe +35 4.42 MB nestjscore
npm/@nestjs/common@10.3.10 None +1 494 kB nestjscore
npm/@nestjs/config@3.2.3 environment, filesystem +1 63.4 kB nestjscore
npm/@nestjs/core@10.3.10 environment, unsafe Transitive: filesystem, network, shell +4 773 kB nestjscore
npm/@nestjs/jwt@10.2.0 None +12 220 kB nestjscore
npm/@nestjs/passport@10.0.3 None 0 21.2 kB nestjscore
npm/@nestjs/platform-express@10.3.10 network Transitive: environment, filesystem, unsafe +23 507 kB nestjscore
npm/@nestjs/schematics@10.1.3 Transitive: eval, network +11 2.36 MB kamilmysliwiec, nestjscore
npm/@nestjs/swagger@7.4.0 Transitive: environment, eval, filesystem +4 3.43 MB nestjscore
npm/@nestjs/testing@10.3.10 None 0 34.7 kB nestjscore
npm/@nestjs/throttler@5.2.0 None 0 203 kB nestjscore
npm/@sentry/nextjs@8.19.0 environment, filesystem, network Transitive: eval, shell, unsafe +221 137 MB sentry-bot
npm/@t3-oss/env-nextjs@0.6.1 environment +1 60.1 kB juliusmarminge
npm/@types/cookie-parser@1.4.7 None 0 5.67 kB types
npm/@types/fs-extra@11.0.4 None +1 42.5 kB types
npm/@types/jest@29.5.12 Transitive: environment +10 511 kB types
npm/@types/luxon@3.4.2 None 0 120 kB types
npm/@types/mailparser@3.4.4 None +3 2.52 MB types
npm/@types/passport-jwt@3.0.13 None +3 71.7 kB types
npm/@types/supertest@2.0.16 None +3 40.5 kB types
npm/body-parser@1.20.2 network Transitive: filesystem, unsafe +7 136 kB dougwilson
npm/class-transformer@0.5.1 None 0 776 kB typestack-release-bot
npm/class-validator@0.14.1 None +2 13.5 MB typestack-release-bot
npm/connect@3.7.0 environment, network Transitive: filesystem +11 229 kB dougwilson
npm/cookie-parser@1.4.6 None +2 34.1 kB dougwilson
npm/dotenv@16.4.5 environment, filesystem 0 79.1 kB motdotla
npm/fs-extra@11.2.0 Transitive: filesystem +1 74.7 kB ryanzim
npm/googleapis@84.0.0 Transitive: environment, filesystem, network, shell +18 93.7 MB google-wombot
npm/helmet@7.1.0 None 0 102 kB evanhahn
npm/http-proxy-middleware@2.0.6 network +3 314 kB chimurai
npm/http@0.0.1-security None 0 464 B andreeleuterio
npm/ioredis@5.4.1 network +4 805 kB ioredis-robot
npm/jest@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +93 3.46 MB simenb
npm/langchain@0.1.37 Transitive: environment, filesystem, network, shell +60 42.7 MB basproul
npm/luxon@3.4.4 None 0 4.33 MB icambron
npm/mailparser@3.7.1 Transitive: environment, filesystem, network, shell +28 4.58 MB andris
npm/memory-cache@0.2.0 None 0 36.7 kB ptarjan
npm/nest-winston@1.10.0 environment +1 71.3 kB gremo
npm/nestjs-throttler-storage-redis@0.4.4 None +1 363 kB kkoomen
npm/next-api-middleware@1.0.1 Transitive: environment +2 85.9 kB htunnicliff
npm/next-auth@4.24.7 environment, network Transitive: filesystem, shell, unsafe +22 1.2 GB thvu
npm/next-axiom@0.17.0 environment, network +1 428 kB lukasmalkmus
npm/next-swagger-doc@0.3.6 Transitive: environment, filesystem, network, shell +23 4.85 MB jellydn
npm/next-validations@0.2.1 eval 0 273 kB jellydn
npm/next@13.5.6 environment, filesystem, network, shell, unsafe +25 1.12 GB vercel-release-bot
npm/node-mocks-http@1.15.0 environment, network Transitive: eval, filesystem +21 374 kB eugef
npm/supports-color@8.1.1 None 0 8.45 kB sindresorhus
npm/tzdata@1.0.40 None 0 444 kB rogierschouten

🚮 Removed packages: npm/@formkit/auto-animate@1.0.0-beta.5, npm/@types/detect-port@1.3.5, npm/@types/lodash@4.17.7, npm/@types/mime-types@2.1.4, npm/@types/node@16.9.1, npm/classnames@2.5.1, npm/ical.js@1.5.0, npm/rrule@2.8.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Telemetry npm/next@13.5.6
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information
🚫
Install scripts npm/@nestjs/core@10.3.10
  • Install script: postinstall
  • Source: opencollective || exit 0
🚫
Telemetry npm/next@14.2.5
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information
🚫
Install scripts npm/@sentry/cli@2.33.0
  • Install script: postinstall
  • Source: node ./scripts/install.js
🚫

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/next@13.5.6
  • @SocketSecurity ignore npm/@nestjs/core@10.3.10
  • @SocketSecurity ignore npm/next@14.2.5
  • @SocketSecurity ignore npm/@sentry/cli@2.33.0

Copy link
Copy Markdown
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super happy that we will have this in CI! Thank you Keith!

@keithwillcode keithwillcode merged commit ca5dcfd into main Jul 24, 2024
@keithwillcode keithwillcode deleted the chore/add-v2-tests-simplified branch July 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth automated-tests area: unit tests, e2e tests, playwright ci area: CI, DX, pipeline, github actions core area: core, team members only foundation Medium priority Created by Linear-GitHub Sync ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants