fix: Change conferencing app-store URL on event types and bookings pages#15878
Conversation
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
|
@Souptik2001 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
github-actions
Bot
added
app-store
Graphite Automations"Add community label" took an action on this PR • (07/23/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (07/23/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (07/23/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
@Souptik2001 Let's change the translation key and value to conferencing, when everything is conferencing instead of video. So, the text would be " Can't find the right conferencing app".
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
|
@anikdhabal Done! Also changed the key from Important note: All translations needs to be updated. |
There was a problem hiding this comment.
Hey @Souptik2001 you don't need to update it in every locale; just change it to /locales/en and rest remove. We handle the rest externally.
|
@anikdhabal Yes that's already done! Thanks! 😄 |
|
@anikdhabal Ahh ok.. you mean the key? I have just changed the key in all the locales (the texts are same), that has to be done right? or you are saying that I will just change the key and text in the Just confirming once before reverting. |
anikdhabal
left a comment
anikdhabal
left a comment
There was a problem hiding this comment.
@Souptik2001 need to remove the key and text for the other locales; for locales/en, you already updated.
Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>
|
@anikdhabal Done! cc: @PeerRich |
And what about removing both the key and text in all locales except |
|
@anikdhabal I meant I did that only, in the above commit. Am I still missing something? 😅 |
|
@anikdhabal I mean it's done, can you please check once. 😅 
|
|
@anikdhabal Ahh oops.. 😅 got it now! I was thinking that those will be only modified when updating translations. Sorry for the back-and-forth. |
All good, yeah i understood 😅 |
anikdhabal
left a comment
anikdhabal
left a comment
There was a problem hiding this comment.
LGTM!
Approving on behalf of @PeerRich and me
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
@anikdhabal Sorry, but the changes done here, are not right. |
|
@suyash5053 FYI the changes were purposeful and made after confirmation - #15878 (review) Anyhow it was just a matter of a revert commit if the text change was not required..🙂 But ok no worries. 👍 |
|
@suyash5053, in our app, most places use 'conferencing' to describe the conferencing app, and we have a 'conferencing' section rather than 'video' for installing the conferencing app in the app store, with the link also redirecting there. Don't you think it makes sense to change it to 'conferencing'? I suggest @Souptik2001 do that. I hope you understand. |
|
@Souptik2001 Ohk, wasn't aware of the fact, No issues, Sorry for the inconvenience casued, if any. |
5 participants
What does this PR do?
/claim #15811
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
http://localhost:3000/event-types/<event_id>?tabName=setupCan't find the right video app? Visit our App Store, the "App store" link should beapps/categories/conferencing.Checklist