Skip to content

feat: refactor drawer component#15892

Merged
sean-brydon merged 8 commits intomainfrom
feat/refactor-drawer-component
Jul 25, 2024
Merged

feat: refactor drawer component#15892
sean-brydon merged 8 commits intomainfrom
feat/refactor-drawer-component

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon commented Jul 24, 2024

What does this PR do?

Refactors sheet to be more structured to allow us to use forms easily inside of it. Instead of hacking the submission we make it actually be able to be wrapped in a form.

Availability edit
CleanShot 2024-07-24 at 13 50 00

Edit User Sheet:
CleanShot 2024-07-24 at 13 50 13
CleanShot 2024-07-24 at 13 50 16

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).

How should this be tested?

Open members edit
or availability edit on timezone buddy

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app Bot requested a review from a team July 24, 2024 12:52
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jul 24, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 9:19am
cal ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 9:19am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 9:19am

sean-brydon
sean-brydon commented Jul 24, 2024
View reviewed changes
Comment thread packages/ui/components/sheet/sheet.tsx
full: "",
},
},
compoundVariants: [
Copy link
Copy Markdown
Member Author

@sean-brydon sean-brydon Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were never used. Lets simplify this a lot

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Jul 24, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

PeerRich
PeerRich previously approved these changes Jul 24, 2024
View reviewed changes
@keithwillcode keithwillcode added this to the v4.4 milestone Jul 24, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) July 24, 2024 13:51
@keithwillcode keithwillcode disabled auto-merge July 24, 2024 14:42
@keithwillcode
Copy link
Copy Markdown
Contributor

keithwillcode commented Jul 25, 2024

@anikdhabal @Amit91848 One of you able to test this? Would like to ship today if possible

@anikdhabal
Copy link
Copy Markdown
Contributor

anikdhabal commented Jul 25, 2024

@anikdhabal @Amit91848 One of you able to test this? Would like to ship today if possible

Let me test

@anikdhabal
Copy link
Copy Markdown
Contributor

anikdhabal commented Jul 25, 2024

Screenshot 2024-07-25 141028
Need to be fixed

@sean-brydon
Copy link
Copy Markdown
Member Author

sean-brydon commented Jul 25, 2024

Screenshot 2024-07-25 141028 Need to be fixed

Hey ermm can you be a bit more specific on what needs fixed here? Do you mean the padding on the bottom? Can't tell from the SC

@anikdhabal
Copy link
Copy Markdown
Contributor

anikdhabal commented Jul 25, 2024

Hey ermm can you be a bit more specific on what needs fixed here? Do you mean the padding on the bottom? Can't tell from the SC

Yeah, the bottom padding.

@sean-brydon
Copy link
Copy Markdown
Member Author

sean-brydon commented Jul 25, 2024

Screenshot 2024-07-25 141028 Need to be fixed

Hey ermm can you be a bit more specific on what needs fixed here? Do you mean the padding on the bottom? Can't tell from the SC

Yeah, the bottom padding.
CleanShot 2024-07-25 at 10 17 30
Fixed

anikdhabal
anikdhabal approved these changes Jul 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, LGTM!

@sean-brydon sean-brydon merged commit 53c37a9 into main Jul 25, 2024
@sean-brydon sean-brydon deleted the feat/refactor-drawer-component branch July 25, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikdhabal anikdhabal anikdhabal approved these changes

@PeerRich PeerRich PeerRich left review comments

Assignees

No one assigned

Labels

consumer core area: core, team members only ready-for-e2e 💻 refactor

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@sean-brydon @keithwillcode @anikdhabal @PeerRich