fix: make max_participants optional#15920
Merged
Udit-takkar merged 2 commits intomainfrom Jul 26, 2024
Merged
Conversation
Udit-takkar
commented
Jul 25, 2024
| room_name: z.string(), | ||
| start_ts: z.number(), | ||
| status: z.string(), | ||
| max_participants: z.number().optional(), |
Contributor
Author
There was a problem hiding this comment.
made this optional. No change in business logic
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (07/25/24)1 reviewer was added to this PR based on Keith Williams's automation. |
PeerRich
approved these changes
Jul 25, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reported here :- https://calcominc.slack.com/archives/C04CWEU35NV/p1721929046568029
Edge Case:- when user clicks on stop recording as soon as meeting was started i.e when duration of recording 0. max_participants property is not returned
Reported here
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?