Conversation
joeauyeung
previously approved these changes
Aug 13, 2024
Contributor
There was a problem hiding this comment.
Saw all my comments have been addressed. I'll approve but let's wait until @CarinaWolli's comments have been addressed before merging.
Member
Author
Should be all of them! Will fix merge conflicts right now |
emrysal
reviewed
Aug 14, 2024
CarinaWolli
previously approved these changes
Aug 14, 2024
Member
CarinaWolli
left a comment
CarinaWolli
left a comment
There was a problem hiding this comment.
some translations are still missing, everything else looks good 🙏
|
|
||
| const mutation = trpc.viewer.attributes.edit.useMutation({ | ||
| onSuccess: () => { | ||
| showToast("Attribute edited successfully", "success"); |
| return ( | ||
| <> | ||
| <LicenseRequired> | ||
| <Meta title="Attribute" description="Edit an attribute for your team members" /> |
Member
There was a problem hiding this comment.
Can we also add translations here?
Contributor
E2E results are ready! |
zomars
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #12738
Loom: https://www.loom.com/share/f2b28f154bb040c7805844fad019f790
How to test: