test: Add E2E tests for orgRedirection=true param#16066
Merged
hariombalhara merged 5 commits intocalcom:mainfrom Aug 13, 2024
Merged
test: Add E2E tests for orgRedirection=true param#16066hariombalhara merged 5 commits intocalcom:mainfrom
hariombalhara merged 5 commits intocalcom:mainfrom
Conversation
|
@ImBIOS is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
automated-tests
Graphite Automations"Add community label" took an action on this PR • (08/05/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (08/05/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
Author
|
@hariombalhara @anikdhabal any update on review? |
| const slugIndex = index ? `-count-${index}` : ""; | ||
| const slug = `${isOrg ? "org" : "team"}-${workerInfo.workerIndex}-${Date.now()}${slugIndex}`; | ||
| const slug = | ||
| orgRequestedSlug ?? `${isOrg ? "org" : "team"}-${workerInfo.workerIndex}-${Date.now()}${slugIndex}`; |
Member
There was a problem hiding this comment.
Shouldn't orgRequestedSlug be made unique as well using similar pattern
hariombalhara
approved these changes
Aug 13, 2024
Member
|
Thanks @ImBIOS !! Great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/claim #14516
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
run these 2 commands in different terminal: