fix: transcribe UI subtitle were blocking chat#16097
Merged
Conversation
Member
PeerRich
commented
Aug 6, 2024
PeerRich
commented
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/06/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
PeerRich
added
the
⚡ Quick Wins
Udit-takkar
reviewed
Aug 7, 2024
Contributor
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
On mobile view It's blocking chat input box
Member
Author
ahh thats gonna be tricky to fix, cause right now the transcription is "outside" of the embed. we could put it higher up but then it looks odd... this PR is still better than before. maybe we just hide transcription on mobile |
PeerRich
commented
Aug 9, 2024
| <DailyProvider callObject={daily}> | ||
| <div | ||
| className="mx-auto" | ||
| className="mx-auto hidden sm:block" |
Member
Author
There was a problem hiding this comment.
@Udit-takkar this should hide transcription on mobile
Udit-takkar
approved these changes
Aug 9, 2024
Member
Author
|
a lot of workflow and webhook related E2E failing here 
|
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.