fix: uncaught types errors in invite members team handler by zomars · Pull Request #16109 · calcom/cal.diy

zomars · 2024-08-06T23:28:17Z

What does this PR do?

Follow up to #15929

Enhanced the inviteMemberUtils and related tests to handle additional organization properties.

What changed?

Updated inviteMemberUtils mock to include and process newRole property in invitations.
Refined return logic to consistently use Promise.resolve
Augmented mocked data to encompass new organization properties such as isOrganization, organizationId, lockEventTypeCreationForUsers, adminGetsNoSlotsNotification, isAdminReviewed, and isAdminAPIEnabled

How to test?

Run the existing unit tests for inviteMemberUtils ensuring all new properties are properly handled.
Any new tests added for the additional functionalities should also pass.

Why make this change?

This change is essential to keep the invite member utility and its tests up-to-date with the evolving schema and business logic regarding organizational properties.

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

vercel · 2024-08-06T23:28:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	❌ Failed (Inspect)			Aug 19, 2024 8:09pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Aug 19, 2024 8:09pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Aug 19, 2024 8:09pm

zomars · 2024-08-06T23:28:38Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zomars and the rest of your teammates on Graphite

graphite-app · 2024-08-06T23:30:11Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (08/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (08/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

joeauyeung

LGTM

github-actions · 2024-08-15T20:37:57Z

E2E results are ready!

Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Morgan Vernay <morgan@cal.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com>

Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com> Co-authored-by: Omar López <zomars@me.com>

Co-authored-by: Omar López <zomars@me.com>

…team_handler

fix: ensures tRPC definitions are built before starting dev scripts (#16111)

…team_handler

CarinaWolli

LGTM

…6109)" This reverts commit a091c60.

…6109)" (#16322) This reverts commit a091c60.

keithwillcode added core area: core, team members only foundation labels Aug 6, 2024

zomars marked this pull request as ready for review August 6, 2024 23:28

graphite-app Bot requested a review from a team August 6, 2024 23:28

dosubot Bot added automated-tests area: unit tests, e2e tests, playwright platform Anything related to our platform plan labels Aug 6, 2024

graphite-app Bot requested a review from a team August 6, 2024 23:29

vercel Bot deployed to Preview – ai August 6, 2024 23:31 View deployment

This was referenced Aug 6, 2024

fix: trpc config to catch previously uncaught errors #16110

Merged

fix: ensures tRPC definitions are built before starting dev scripts #16111

Merged

vercel Bot deployed to Preview – api August 6, 2024 23:36 View deployment

zomars added the ready-for-e2e label Aug 6, 2024

vercel Bot deployed to Preview – dev August 6, 2024 23:53 View deployment

zomars force-pushed the refactor_use_webhookservice_in_payments_router branch from 576afa9 to eeb720a Compare August 8, 2024 18:17

zomars force-pushed the fix_uncaught_types_errors_in_invite_members_team_handler branch from ab68ca3 to c8ef909 Compare August 8, 2024 18:18

vercel Bot had a problem deploying to Preview – ai August 8, 2024 18:18 Failure

vercel Bot deployed to Preview – api August 8, 2024 18:27 View deployment

vercel Bot deployed to Preview – dev August 8, 2024 18:52 View deployment

joeauyeung previously approved these changes Aug 15, 2024

View reviewed changes

zomars changed the base branch from refactor_use_webhookservice_in_payments_router to graphite-base/16109 August 15, 2024 20:03

fix: uncaught types errors in invite members team handler

d2651fb

zomars force-pushed the fix_uncaught_types_errors_in_invite_members_team_handler branch from c8ef909 to d2651fb Compare August 15, 2024 20:03

vercel Bot deployed to Preview – api August 15, 2024 20:11 View deployment

joeauyeung previously approved these changes Aug 15, 2024

View reviewed changes

joeauyeung enabled auto-merge (squash) August 15, 2024 20:14

zomars added ready-for-e2e and removed ready-for-e2e labels Aug 15, 2024

vercel Bot deployed to Preview – dev August 15, 2024 20:24 View deployment

Ryukemeister and others added 9 commits August 16, 2024 12:09

feat: destination calendar settings for CalendarSettings atom (#16133)

c573bdb

Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Morgan Vernay <morgan@cal.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com>

fix: pipeline permissions for label action (#16220)

4435249

feat: attributes (#15964)

8904b72

Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com> Co-authored-by: Omar López <zomars@me.com>

chore: Release v4.4.0 (#16219)

5ad69ae

Co-authored-by: Omar López <zomars@me.com>

Change body from HTML to text (#16217)

82d9355

fix: uncaught errors in WebhookService

ab31a68

fix: uncaught errors in sendPayload

38421f1

Update inviteMember.handler.test.ts

3b1fcee

Merge branch 'main' into fix_uncaught_types_errors_in_invite_members_…

5a4bf32

…team_handler

zomars dismissed joeauyeung’s stale review via 5a4bf32 August 16, 2024 19:18

zomars requested a review from joeauyeung August 16, 2024 19:18

vercel Bot deployed to Preview – api August 16, 2024 19:27 View deployment

vercel Bot deployed to Preview – dev August 16, 2024 19:34 View deployment

zomars added 2 commits August 19, 2024 13:08

fix: trpc config to catch previously uncaught errors (#16110)

118dbf8

fix: ensures tRPC definitions are built before starting dev scripts (#16111)

Merge branch 'main' into fix_uncaught_types_errors_in_invite_members_…

2315e80

…team_handler

CarinaWolli approved these changes Aug 19, 2024

View reviewed changes

vercel Bot deployed to Preview – api August 19, 2024 20:23 View deployment

joeauyeung merged commit a091c60 into main Aug 19, 2024

joeauyeung deleted the fix_uncaught_types_errors_in_invite_members_team_handler branch August 19, 2024 20:27

vercel Bot deployed to Preview – dev August 19, 2024 20:40 View deployment

emrysal added a commit that referenced this pull request Aug 22, 2024

Revert "fix: uncaught types errors in invite members team handler (#1…

4516245

…6109)" This reverts commit a091c60.

emrysal added a commit that referenced this pull request Aug 23, 2024

Revert "fix: uncaught types errors in invite members team handler (#1…

fd50728

…6109)" (#16322) This reverts commit a091c60.

zomars pushed a commit that referenced this pull request Aug 29, 2024

Revert "fix: uncaught types errors in invite members team handler (#1…

7734052

…6109)" (#16322) This reverts commit a091c60.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: uncaught types errors in invite members team handler#16109

fix: uncaught types errors in invite members team handler#16109
joeauyeung merged 12 commits intomainfrom
fix_uncaught_types_errors_in_invite_members_team_handler

zomars commented Aug 6, 2024 •

edited

Loading

Uh oh!

vercel Bot commented Aug 6, 2024 •

edited

Loading

Uh oh!

zomars commented Aug 6, 2024 •

edited

Loading

Uh oh!

graphite-app Bot commented Aug 6, 2024

Uh oh!

joeauyeung left a comment

Uh oh!

github-actions Bot commented Aug 15, 2024 •

edited

Loading

Uh oh!

CarinaWolli left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

zomars commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What changed?

How to test?

Why make this change?

Mandatory Tasks (DO NOT REMOVE)

Checklist

Uh oh!

vercel Bot commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zomars commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app Bot commented Aug 6, 2024

Graphite Automations

Uh oh!

joeauyeung left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

CarinaWolli left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zomars commented Aug 6, 2024 •

edited

Loading

vercel Bot commented Aug 6, 2024 •

edited

Loading

zomars commented Aug 6, 2024 •

edited

Loading

github-actions Bot commented Aug 15, 2024 •

edited

Loading