revert: fix: #15857 add managed by tooltip#16139
Merged
Conversation
keithwillcode
added
core
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/08/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Contributor
|
@Udit-takkar Don't forgot not everyone referencing this issue in the future will have access to campsite, most won't. That aside revert looks good. |
emrysal
approved these changes
Aug 9, 2024
Contributor
|
@Udit-takkar , may i know the reason for this revert please, dont have access to campsite |
Amit91848
reviewed
Aug 13, 2024
Comment on lines
-53
to
-74
| parent: { | ||
| select: { | ||
| team: { | ||
| select: { | ||
| id: true, | ||
| members: { | ||
| select: { | ||
| user: { | ||
| select: { | ||
| name: true, | ||
| username: true, | ||
| email: true, | ||
| }, | ||
| }, | ||
| role: true, | ||
| accepted: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, |
Member
There was a problem hiding this comment.
Too much nesting here, was slowing down queries considerably for organization with a lot of members @vijayraghav-io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
reverts:- #15861
Ref:- https://app.campsite.co/cal/posts/w48wccpcokqi#comment-21dndamompgk
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?