feat: e2e reports in gh-pages by zomars · Pull Request #16179 · calcom/cal.diy

zomars · 2024-08-12T23:32:51Z

What does this PR do?

Fixes DOPS-39
Fixes [CAL-4140] Proposal: Enhancing Visibility of E2E Test Results #16192

This pull request updates several GitHub Actions workflows to improve caching, report handling, and clean-up processes.

What changed?

Caching:
- Removed restore-keys from yarn install action.
- Modified playwright install action to better cache Playwright binaries based on the installed version.
Reports:
- Added new workflows to merge and publish HTML reports.
- Modified e2e workflow to upload test results with specific retention and naming conventions.
Clean-up:
- Introduced a new workflow to automatically clean up reports of deleted branches.

How to test?

Observe GitHub Actions runs for successful completion and correct behavior.
Ensure that caching and report publishing happens correctly.
Check that clean-up is triggered correctly on branch deletions.

Why make this change?

To optimize CI/CD workflows by improving caching strategies, enhancing report management, and automating clean-up tasks.

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

Signed-off-by: zomars <zomars@me.com> # Conflicts: # .github/workflows/pr.yml

…oysentinel-as-playwright-support-is-deprecated

zomars · 2024-08-13T20:48:49Z

-        restore-keys: |
-          yarn-download-cache-


Prevent stale caches. Only exact matches should be used.

zomars · 2024-08-13T20:49:18Z

          ${{ github.workspace }}/node_modules/playwright
-        key: cache-playwright-${{ hashFiles('**/yarn.lock') }}
-        restore-keys: cache-playwright-
+        key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}


Only bust playwright cache when the version actually changes. Not when any other dependency changes.

zomars · 2024-08-13T20:53:29Z

  fullyParallel: true,
  reporter: [
-    [process.env.CI ? "github" : "list"],
+    [process.env.CI ? "blob" : "list"],


the GitHub reporter is not useful since we're using matrix strategies. https://playwright.dev/docs/test-reporters#github-actions-annotations

* Add bookingSuccessful event for recurring booking * Remove unused variable

…ckable before flicker, and fix timezone issue (#16001) * test: prevent modal button clickable before flicker * chore: add note to migrate to appDir to solve full page flicker issue * chore: Improve OutOfOfficePage loading experience Refactor the OutOfOfficePage component to improve the loading experience by using the `isPending` property from the `trpc.viewer.outOfOfficeReasonList.useQuery()` hook. This workaorund eliminates the full page flicker issue and provides a better user experience. The "Add" button now shows a loading state when the query is pending. * Update index.tsx * chore: Update outOfOffice.handler.ts to use input.offset instead of calculating offset * fix e2e * Update * revert * chore: Fix offset calculation for out of office bookings * chore: Update date range calculation for out-of-office modal * chore: Remove console.log statement in out-of-office modal * chore: Update TimeZoneEnum with additional time zones This commit updates the TimeZoneEnum in the types.ts file to include additional time zones. The new time zones added are: - ID: Asia/Jakarta (UTC+7) - SAMOA: Etc/GMT+12 (UTC-12) - AMERICAN_SAMOA: Pacific/Pago_Pago (UTC-11) - HAWAII: Pacific/Honolulu (UTC-10) - ALASKA: America/Anchorage (UTC-9) - PACIFIC_USA: America/Los_Angeles (UTC-8) - CENTRAL_USA: America/Chicago (UTC-6) - EASTERN_USA: America/New_York (UTC-5) - VENEZUELA: America/Caracas (UTC-4) - ARGENTINA: America/Buenos_Aires (UTC-3) - BRAZIL: America/Noronha (UTC-2) - AZORES: Atlantic/Azores (UTC-1) - FRANCE: Europe/Paris (UTC+1) - GREECE: Europe/Athens (UTC+2) - RUSSIA: Europe/Moscow (UTC+3) - UAE: Asia/Dubai (UTC+4) - PAKISTAN: Asia/Karachi (UTC+5) - BANGLADESH: Asia/Dhaka (UTC+6) - SINGAPORE: Asia/Singapore (UTC+8) - JAPAN: Asia/Tokyo (UTC+9) - AUSTRALIA: Australia/Sydney (UTC+10) - SOLOMON_ISLANDS: Pacific/Guadalcanal (UTC+11) - NEW_ZEALAND: Pacific/Auckland (UTC+12) The purpose of this update is to provide a comprehensive list of time zones for users to choose from when setting their time zone in the out-of-office feature. * update * fix * remove comment --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: unknown <adhabal2002@gmail.com>

* fix: scheduleId not unset properly bug * Refactor almost complete, couple of tests needed * More testid fixes * Add migration to fixup schedule id bug * Remove migration * fix: Refactor useLockedFieldManager for correct useState use --------- Co-authored-by: zomars <zomars@me.com>

* dumb components for calendar settings * shadcn switch * update exports * update packages * add calendar settings atom to examples app * init calendar settings atom * refactors * fix import path * export type for calendar switch props * invalidate queries on deleting calendar credentials * replace calendars list with calendar settings wrapper * cleanup * update styling * refactors * cleanup * fix: missing key prop CalendarSettingsPlatformWrapper * Label as client components * Address client component build errors * Move QueryCell out of packages/lib * PR feedback * more feedback --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Morgan Vernay <morgan@cal.com> Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com>

…wright-support-is-deprecated

CLAassistant · 2024-08-13T20:55:57Z

All committers have signed the CLA.

emrysal

Quick typo fix, ready to merge, let's go 🚀

keithwillcode and others added 30 commits June 22, 2024 18:11

Added a log for pull_request

5c6d9a7

Added labels logging

7febdaf

Using labels straight from event PR object

ce291ee

Converting to JSON

7283309

Switching to use payload

e352554

Fixed issue with undefined pr

97387df

Fixed non-mapping issue

2ff9093

Removed the types

20466ea

Added another cache key segment using the head commit sha

4a9b72f

Added separate workflow for labeled action

7270f28

Fixed syntax error

9d7b620

Fixing payload issue

f0516cd

Added log

a33f59b

logging full object

f4e1d09

Put e2e back in the names to help find them

c12466f

Limited logging

a769606

Hardcode the timezone

e0b49e3

Removing shards to see if any effect

3197e51

Temporarily remove build caching to test

a85e748

Added back build caching

169c2c4

Added back test shards

da77755

Removed output: 'standalone'

c16382c

Blocking tests until builds finish

f6faf84

copy/pasted the jobs from all checks

c760f69

Merge remote-tracking branch 'origin/main' into gh-actions-test-branch

c19e4ea

Put back output:standalone

ce30da2

Putting back the changes/needs label jobs just to verify

30c960b

WIP

149f5c4

Merge branch 'main' into gh-actions-test-branch

083c53a

Signed-off-by: zomars <zomars@me.com> # Conflicts: # .github/workflows/pr.yml

WIP

5efb305

Merge branch 'gh-actions-test-branch' into zomars/dops-39-remove-depl…

2419e68

…oysentinel-as-playwright-support-is-deprecated

vercel Bot deployed to Preview – dev August 13, 2024 20:40 View deployment

zomars changed the base branch from gh-actions-test-branch to main August 13, 2024 20:45

zomars commented Aug 13, 2024

View reviewed changes

vercel Bot deployed to Preview – api August 13, 2024 20:50 View deployment

zomars added 3 commits August 13, 2024 13:51

Update merge-reports.yml

b35aef7

Discard changes to .github/workflows/pr-labeled.yml

582e72c

Discard changes to package.json

36d61c8

zomars commented Aug 13, 2024

View reviewed changes

hariombalhara and others added 7 commits August 13, 2024 13:55

fix: Add booking related events for recurring bookings as well (#16180)

c0544ad

* Add bookingSuccessful event for recurring booking * Remove unused variable

test: Add E2E tests for orgRedirection=true param (#16066)

fcebd0f

fix: Replace empty user name with user email (#16176)

a1889db

Merge branch 'main' into zomars/dops-39-remove-deploysentinel-as-play…

66094da

…wright-support-is-deprecated

zomars enabled auto-merge (squash) August 13, 2024 21:03

vercel Bot deployed to Preview – api August 13, 2024 21:07 View deployment

vercel Bot deployed to Preview – dev August 13, 2024 21:13 View deployment

emrysal reviewed Aug 13, 2024

View reviewed changes

Comment thread .github/workflows/publish-report.yml Outdated

Fix typo

0f2b6da

github-actions Bot added the automated-tests area: unit tests, e2e tests, playwright label Aug 13, 2024

emrysal approved these changes Aug 13, 2024

View reviewed changes

vercel Bot deployed to Preview – api August 13, 2024 21:22 View deployment

vercel Bot deployed to Preview – dev August 13, 2024 21:29 View deployment

zomars merged commit f206b3d into main Aug 13, 2024

zomars deleted the zomars/dops-39-remove-deploysentinel-as-playwright-support-is-deprecated branch August 13, 2024 21:50

zomars mentioned this pull request Aug 14, 2024

test: merge all e2e reports #16202

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: e2e reports in gh-pages#16179

feat: e2e reports in gh-pages#16179
zomars merged 62 commits intomainfrom
zomars/dops-39-remove-deploysentinel-as-playwright-support-is-deprecated

zomars commented Aug 12, 2024 •

edited

Loading

Uh oh!

zomars Aug 13, 2024

Uh oh!

zomars Aug 13, 2024

Uh oh!

zomars Aug 13, 2024

Uh oh!

CLAassistant commented Aug 13, 2024 •

edited

Loading

Uh oh!

Uh oh!

emrysal left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

zomars commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What changed?

How to test?

Why make this change?

Mandatory Tasks (DO NOT REMOVE)

Checklist

Uh oh!

zomars Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

zomars Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

zomars Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zomars commented Aug 12, 2024 •

edited

Loading

CLAassistant commented Aug 13, 2024 •

edited

Loading