Skip to content

fix: Add booking related events for recurring bookings as well#16180

Merged
hariombalhara merged 2 commits intomainfrom
add-bookingSuccessful-for-recurring
Aug 13, 2024
Merged

fix: Add booking related events for recurring bookings as well#16180
hariombalhara merged 2 commits intomainfrom
add-bookingSuccessful-for-recurring

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Aug 13, 2024 •
edited
Loading

What does this PR do?

Add bookingSuccessfulV2 and rescheduleBookingSuccessfulV2 event for recurring bookings

Loom: https://www.loom.com/share/d43cdccb8c0d4eb0a99d6500bdd591c1

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Simply do the booking through embed and look for the events.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 13, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add bookingSuccessful event for recurring booking". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Aug 13, 2024
@hariombalhara hariombalhara force-pushed the add-bookingSuccessful-for-recurring branch from 1751f06 to 36d3670 Compare August 13, 2024 06:40
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 8:18am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 8:18am

@hariombalhara hariombalhara changed the title Add bookingSuccessful event for recurring booking fix: Add bookingSuccessfulV2 event for recurring bookings as well Aug 13, 2024
@hariombalhara hariombalhara changed the title fix: Add bookingSuccessfulV2 event for recurring bookings as well fix: Add booking related events for recurring bookings as well Aug 13, 2024
@hariombalhara hariombalhara force-pushed the add-bookingSuccessful-for-recurring branch from 36d3670 to ab448ac Compare August 13, 2024 06:43
@hariombalhara hariombalhara marked this pull request as ready for review August 13, 2024 06:46
@graphite-app graphite-app Bot requested a review from a team August 13, 2024 06:46
@dosubot dosubot Bot added the bookings area: bookings, availability, timezones, double booking label Aug 13, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 13, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hariombalhara hariombalhara force-pushed the add-bookingSuccessful-for-recurring branch from ab448ac to 847980d Compare August 13, 2024 06:50
@hariombalhara hariombalhara force-pushed the add-bookingSuccessful-for-recurring branch from 847980d to e05026b Compare August 13, 2024 06:52
hariombalhara
hariombalhara commented Aug 13, 2024
View reviewed changes
Comment thread packages/features/bookings/Booker/components/hooks/useBookings.ts
mutationFn: createBooking,
onSuccess: (responseData) => {
const { uid, paymentUid } = responseData;
onSuccess: (booking) => {
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a rename for better understanding

hariombalhara
hariombalhara commented Aug 13, 2024
View reviewed changes
Comment thread packages/features/bookings/lib/create-booking.ts

export const createBooking = async (data: BookingCreateBody) => {
const response = await post<
Omit<BookingCreateBody, "startTime" | "endTime">,
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit was being done on wrong object. BookingCreateBody doesn't event have those props

alishaz-polymath
alishaz-polymath approved these changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@hariombalhara hariombalhara enabled auto-merge (squash) August 13, 2024 10:01
@hariombalhara hariombalhara merged commit c36249b into main Aug 13, 2024
@hariombalhara hariombalhara deleted the add-bookingSuccessful-for-recurring branch August 13, 2024 10:25
zomars pushed a commit that referenced this pull request Aug 13, 2024
@hariombalhara @zomars
fix: Add booking related events for recurring bookings as well (#16180)
c0544ad 
* Add bookingSuccessful event for recurring booking

* Remove unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alishaz-polymath alishaz-polymath alishaz-polymath approved these changes

Assignees

No one assigned

Labels

bookings area: bookings, availability, timezones, double booking core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hariombalhara @alishaz-polymath @keithwillcode