Skip to content

fix: doesn't fall back to calvideo if wrong destination is used for google meet#16195

Merged
CarinaWolli merged 1 commit intocalcom:mainfrom
kart1ka:fix/wrong-destination-cal-for-google-meet
Aug 14, 2024
Merged

fix: doesn't fall back to calvideo if wrong destination is used for google meet#16195
CarinaWolli merged 1 commit intocalcom:mainfrom
kart1ka:fix/wrong-destination-cal-for-google-meet

Conversation

@kart1ka
Copy link
Copy Markdown
Collaborator

@kart1ka kart1ka commented Aug 14, 2024

What does this PR do?

Loom Video: https://www.loom.com/share/5755e62f0b3b4dd89e7ace6588552f01?sid=5a613d57-5166-412f-b48a-378b7fa48a9c

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. N/A.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Set a non google calendar as the destination calendar for an event.
  • Set google meet as location value for the event.
  • Now try to make a booking for that event.
  • Notice that cal video is used as a fallback.

Checklist

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 14, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Aug 14, 2024
@graphite-app graphite-app Bot requested a review from a team August 14, 2024 08:50
@github-actions github-actions Bot added Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Aug 14, 2024
@dosubot dosubot Bot added this to the v4.5 milestone Aug 14, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 14, 2024

Graphite Automations

"Add community label" took an action on this PR • (08/14/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (08/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@CarinaWolli CarinaWolli merged commit 3f2d83d into calcom:main Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-4129] Doesn't fall back to calvideo if wrong destination is used for Google Meet

3 participants