Skip to content

fix: Close.com can't be installed#16196

Merged
keithwillcode merged 3 commits intocalcom:mainfrom
Flash-Shivam:bug-fix-close
Aug 20, 2024
Merged

fix: Close.com can't be installed#16196
keithwillcode merged 3 commits intocalcom:mainfrom
Flash-Shivam:bug-fix-close

Conversation

@Flash-Shivam
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes the below issues

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Tested locally

https://www.loom.com/share/9b7f1f23af604cc594476a6bb07fd84c?sid=aa62fa96-f27d-4281-9488-7d3fc287f788

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Aug 14, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 14, 2024

@Flash-Shivam is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot requested a review from a team August 14, 2024 10:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 14, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix : Close.com can't be installed". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions Bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid 🐛 bug Something isn't working labels Aug 14, 2024
@dosubot dosubot Bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Aug 14, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 14, 2024

Graphite Automations

"Add community label" took an action on this PR • (08/14/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (08/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal changed the title fix : Fix for #16183 , [CAL-3969] fix : Close.com can't be installed Aug 14, 2024
@anikdhabal anikdhabal changed the title fix : Close.com can't be installed fix: Close.com can't be installed Aug 14, 2024
Comment thread packages/app-store/closecom/pages/setup/index.tsx Outdated
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 14, 2024

E2E results are ready!

@keithwillcode keithwillcode merged commit 86f8c6c into calcom:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working community Created by Linear-GitHub Sync crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-3969] Close.com can't be installed

4 participants