Merged
Conversation
Signed-off-by: zomars <zomars@me.com>
Signed-off-by: zomars <zomars@me.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
…wright-support-is-deprecated-1
Contributor
E2E results are ready! |
joeauyeung
approved these changes
Aug 14, 2024
Contributor
joeauyeung
left a comment
joeauyeung
left a comment
There was a problem hiding this comment.
Not sure about the specific path but changes LGTM.
zomars
deleted the
zomars/dops-39-remove-deploysentinel-as-playwright-support-is-deprecated-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
follow up to #16179
Updated artifact naming and paths for E2E test results and adjusted workflow dependencies.
What changed?
How to test?
Why make this change?
This change standardizes the naming convention for E2E test artifacts and ensures that report merging and publishing only occur when E2E tests are actually run. This improves consistency in artifact handling and optimizes workflow execution.
Mandatory Tasks (DO NOT REMOVE)
Checklist