Skip to content

fix: missing pipeline dependecies#16205

Merged
zomars merged 1 commit intomainfrom
fix-missing-pipeline-deps
Aug 14, 2024
Merged

fix: missing pipeline dependecies#16205
zomars merged 1 commit intomainfrom
fix-missing-pipeline-deps

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Aug 14, 2024 •
edited
Loading

What does this PR do?

Updated conditions and dependencies for merge-reports and publish-report jobs in PR workflow.

What changed?

  • Added a new condition needs.changes.outputs.has-files-requiring-all-checks == 'true' to both merge-reports and publish-report jobs.
  • Expanded the needs array for merge-reports job to include changes, e2e-embed, e2e-embed-react, and e2e-app-store.
  • Added 'changes' to the needs array for the publish-report job.

How to test?

  1. Create a pull request that triggers the PR workflow.
  2. Verify that the merge-reports and publish-report jobs only run when all conditions are met, including the new condition for files requiring all checks.
  3. Ensure that the merge-reports job waits for the completion of all e2e-related jobs before running.

Why make this change?

This change improves the efficiency and accuracy of the PR workflow by:

  1. Ensuring that report merging and publishing only occur when necessary (i.e., when files requiring all checks have been modified).
  2. Guaranteeing that all relevant e2e test results are included in the merged reports.
  3. Reducing unnecessary workflow runs, potentially saving time and computational resources.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@zomars Graphite App
Copy link
Copy Markdown
Contributor Author

zomars commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zomars and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added core area: core, team members only foundation labels Aug 14, 2024
@zomars zomars marked this pull request as ready for review August 14, 2024 20:15
@graphite-app graphite-app Bot requested a review from a team August 14, 2024 20:15
@dosubot dosubot Bot added automated-tests area: unit tests, e2e tests, playwright ci area: CI, DX, pipeline, github actions labels Aug 14, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 14, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (08/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@zomars zomars enabled auto-merge (squash) August 14, 2024 20:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 14, 2024 •
edited
Loading

E2E results are ready!

@zomars zomars merged commit a11242e into main Aug 14, 2024
@zomars zomars deleted the fix-missing-pipeline-deps branch August 14, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees

No one assigned

Labels

automated-tests area: unit tests, e2e tests, playwright ci area: CI, DX, pipeline, github actions core area: core, team members only foundation ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zomars @PeerRich @keithwillcode