Skip to content

fix: pipeline permissions for label action#16220

Merged
zomars merged 1 commit intomainfrom
fix-pipeline-permissions
Aug 15, 2024
Merged

fix: pipeline permissions for label action#16220
zomars merged 1 commit intomainfrom
fix-pipeline-permissions

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Aug 15, 2024

What does this PR do?

Added permissions to the PR review workflow.

What changed?

Added explicit permissions for actions, issues, and pull requests to the label-pr job in the PR review workflow.

How to test?

  1. Create a new pull request
  2. Have someone review and approve the PR
  3. Verify that the workflow runs successfully and applies the appropriate label

Why make this change?

This change ensures that the workflow has the necessary permissions to read actions, write to issues, and modify pull requests. It follows GitHub's best practices for security by explicitly defining the required permissions, rather than relying on default settings.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Aug 15, 2024 8:20pm
calcom-web-canary ⬜️ Ignored (Inspect) Aug 15, 2024 8:20pm

@github-actions
Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Update pr-review.yml". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@zomars zomars changed the title Update pr-review.yml fix: pipeline permissions for label action Aug 15, 2024
@keithwillcode keithwillcode added core area: core, team members only foundation labels Aug 15, 2024
@dosubot dosubot Bot added the ci area: CI, DX, pipeline, github actions label Aug 15, 2024
@graphite-app graphite-app Bot requested a review from a team August 15, 2024 20:24
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 15, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (08/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci area: CI, DX, pipeline, github actions core area: core, team members only foundation ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants