Skip to content

fix: cal video bug fix and improvements#16234

Merged
PeerRich merged 6 commits intomainfrom
fix/black-rectangle
Aug 18, 2024
Merged

fix: cal video bug fix and improvements#16234
PeerRich merged 6 commits intomainfrom
fix/black-rectangle

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Aug 16, 2024 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Fixed black rectangle in cal video room with transcription feature available
Screenshot 2024-08-16 at 3 19 35 PM

  • Display status of user actions like recording stopping, transcription starting...

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@graphite-app graphite-app Bot requested a review from a team August 16, 2024 09:50
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Aug 16, 2024
@dosubot dosubot Bot added cal video 🐛 bug Something isn't working labels Aug 16, 2024
Udit-takkar
Udit-takkar commented Aug 16, 2024
View reviewed changes
Comment thread apps/web/modules/videos/ai/ai-transcribe.tsx Outdated

return (
<>
transcript && (
Copy link
Copy Markdown
Contributor Author

@Udit-takkar Udit-takkar Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the rectangle bug

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 16, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

PeerRich
PeerRich previously approved these changes Aug 16, 2024
View reviewed changes
@PeerRich PeerRich enabled auto-merge (squash) August 16, 2024 09:57
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Aug 16, 2024

ah thats my bad

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2024 4:59am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2024 4:59am

@PeerRich PeerRich merged commit a51524e into main Aug 18, 2024
@PeerRich PeerRich deleted the fix/black-rectangle branch August 18, 2024 09:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 18, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarinaWolli CarinaWolli CarinaWolli approved these changes

@PeerRich PeerRich PeerRich left review comments

Assignees

No one assigned

Labels

🐛 bug Something isn't working cal video core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Udit-takkar @PeerRich @CarinaWolli @hariombalhara @keithwillcode @ThyMinimalDev