Skip to content

fix: type issues in attributes-edit-view#16243

Merged
keithwillcode merged 2 commits intomainfrom
fix_type_issues_in_attributes-edit-view
Aug 19, 2024
Merged

fix: type issues in attributes-edit-view#16243
keithwillcode merged 2 commits intomainfrom
fix_type_issues_in_attributes-edit-view

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Aug 16, 2024

What does this PR do?

Improved attribute editing functionality and error handling in the organizations settings page.

image.png

What changed?

  • Updated the way the attribute ID is extracted from URL parameters
  • Ensured consistent usage of the id variable throughout the component
  • Removed unnecessary type assertion for the id parameter

How to test?

  1. Navigate to the organization settings page
  2. Attempt to edit an existing attribute
  3. Verify that the attribute details are correctly loaded and can be edited
  4. Submit the changes and confirm they are saved successfully
  5. Check that the attribute list is updated after editing

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 10:28am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 10:28am

Copy link
Copy Markdown
Contributor Author

zomars commented Aug 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zomars and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added core area: core, team members only foundation labels Aug 16, 2024
@zomars zomars marked this pull request as ready for review August 16, 2024 15:13
@graphite-app graphite-app Bot requested a review from a team August 16, 2024 15:13
@dosubot dosubot Bot added organizations area: organizations, orgs ui area: UI, frontend, button, form, input labels Aug 16, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 16, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (08/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 16, 2024

E2E results are ready!

@keithwillcode keithwillcode enabled auto-merge (squash) August 19, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only foundation organizations area: organizations, orgs ready-for-e2e ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants