Skip to content

chore: update icons list#16263

Merged
PeerRich merged 1 commit intomainfrom
update-icon-list
Aug 19, 2024
Merged

chore: update icons list#16263
PeerRich merged 1 commit intomainfrom
update-icon-list

Conversation

@Ryukemeister
Copy link
Copy Markdown
Contributor

@Ryukemeister Ryukemeister commented Aug 19, 2024 •
edited
Loading

What does this PR do?

  • Adds calendar days icon from lucide react since we use that in atoms

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

It can be tested anywhere in the webapp, we just need to pass in calendar days as icon name in the Icon component

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Aug 19, 2024
@dosubot dosubot Bot added the ui area: UI, frontend, button, form, input label Aug 19, 2024
@graphite-app graphite-app Bot requested a review from a team August 19, 2024 09:00
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 19, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (08/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Ryukemeister Ryukemeister requested a review from a team August 19, 2024 09:29
@PeerRich PeerRich enabled auto-merge (squash) August 19, 2024 09:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 19, 2024 •
edited
Loading

E2E results are ready!

@PeerRich PeerRich merged commit df98274 into main Aug 19, 2024
@PeerRich PeerRich deleted the update-icon-list branch August 19, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal approved these changes

@PeerRich PeerRich PeerRich approved these changes

Assignees

No one assigned

Labels

core area: core, team members only platform Anything related to our platform plan ready-for-e2e ui area: UI, frontend, button, form, input

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ryukemeister @emrysal @PeerRich @keithwillcode