fix: v1 api payments endpoint fix#16264
Merged
keithwillcode merged 5 commits intomainfrom Aug 19, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
github-actions
Bot
added
api
keithwillcode
added
core
alishaz-polymath
removed
the
enterprise
| import { _PaymentModel as Payment } from "@calcom/prisma/zod"; | ||
|
|
||
| // FIXME: Payment seems a delicate endpoint, do we need to remove anything here? | ||
| export const schemaPaymentBodyParams = Payment.omit({ id: true }); |
Member
Author
There was a problem hiding this comment.
There is no POST here, so we don't need this.
Comment on lines
+3
to
+12
| export const schemaPaymentPublic = Payment.pick({ | ||
| id: true, | ||
| amount: true, | ||
| success: true, | ||
| refunded: true, | ||
| fee: true, | ||
| paymentOption: true, | ||
| currency: true, | ||
| bookingId: true, | ||
| }); |
Member
Author
There was a problem hiding this comment.
Explicit properties pick
keithwillcode
approved these changes
Aug 19, 2024
keithwillcode
added
the
enterprise
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes our V1 Payment endpoint which showed a mountain of zod errors. The endpoint works after this fix with relevant data returned from the endpoints
api/v1/paymentsapi/v1/payments[id]Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Just check the two endpoints and they should return error free valid response
Checklist