Skip to content

chore: Remove Pages Router / Use App Router - more, maintenance, upgrade, connect-and-join#16531

Merged
hbjORbj merged 4 commits intomainfrom
app-router/more-deploy
Dec 10, 2024
Merged

chore: Remove Pages Router / Use App Router - more, maintenance, upgrade, connect-and-join#16531
hbjORbj merged 4 commits intomainfrom
app-router/more-deploy

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Sep 6, 2024

What does this PR do?

  • Fixes CAL-4279
  • Remove more, maintenance, upgrade, connect-and-join routes from Pages Router and render them from App router.
Screenshot 2024-12-10 at 3 27 29 PM Screenshot 2024-12-10 at 3 27 42 PM Screenshot 2024-12-10 at 3 28 14 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Navigate to:
  1. https://dev-1kl7qdtkd-cal-staging.vercel.app/upgrade
  2. https://dev-1kl7qdtkd-cal-staging.vercel.app/maintenance
  3. https://dev-1kl7qdtkd-cal-staging.vercel.app/more
  4. https://dev-1kl7qdtkd-cal-staging.vercel.app/connect-and-join

@linear
Copy link
Copy Markdown

linear Bot commented Sep 6, 2024

@graphite-app graphite-app Bot requested a review from a team September 6, 2024 17:34
@hbjORbj hbjORbj added the high-risk Requires approval by Foundation team label Sep 6, 2024
@github-actions github-actions Bot added the ❗️ .env changes contains changes to env variables label Sep 6, 2024
@graphite-app graphite-app Bot requested a review from a team September 6, 2024 17:34
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 6, 2024
@dosubot dosubot Bot added the 💻 refactor label Sep 6, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Sep 6, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title chore: [final phase of app router migration] Remove Pages Router / Render App Router - more, maintenance, upgrade, connect-and-join [DO NOT MERGE YET] chore: [final phase of app router migration] Remove Pages Router / Render App Router - more, maintenance, upgrade, connect-and-join Sep 9, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[DO NOT MERGE YET] chore: [final phase of app router migration] Remove Pages Router / Render App Router - `more`, `maintenance`, `upgrade`, `connect-and-join`". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added this to the v4.5 milestone Sep 11, 2024
joeauyeung
joeauyeung previously approved these changes Sep 12, 2024
Copy link
Copy Markdown
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting to see! Great work so far @hbjORbj

@keithwillcode keithwillcode modified the milestones: v4.5, v4.6 Sep 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions Bot added the Stale label Sep 30, 2024
@zomars zomars marked this pull request as draft October 15, 2024 16:16
@zomars
Copy link
Copy Markdown
Contributor

zomars commented Oct 15, 2024

Re-drafting due the [DO NOT MERGE YET] notice

@github-actions github-actions Bot removed the Stale label Oct 16, 2024
@keithwillcode keithwillcode modified the milestones: v4.6, v4.7 Oct 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions Bot added the Stale label Oct 31, 2024
@keithwillcode keithwillcode modified the milestones: v4.7, v4.8 Nov 18, 2024
@github-actions github-actions Bot removed the Stale label Nov 20, 2024
@hbjORbj hbjORbj changed the title [DO NOT MERGE YET] chore: [final phase of app router migration] Remove Pages Router / Render App Router - more, maintenance, upgrade, connect-and-join chore: Remove Pages Router / Use App Router - more, maintenance, upgrade, connect-and-join Dec 10, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 4:38pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 4:38pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 10, 2024

E2E results are ready!

@hbjORbj hbjORbj requested review from eunjae-lee and zomars and removed request for a team December 10, 2024 20:29
@hbjORbj hbjORbj marked this pull request as ready for review December 10, 2024 20:30
@dosubot dosubot Bot added the foundation label Dec 10, 2024
@hbjORbj hbjORbj enabled auto-merge (squash) December 10, 2024 20:32
@hbjORbj hbjORbj merged commit c2c082c into main Dec 10, 2024
@hbjORbj hbjORbj deleted the app-router/more-deploy branch December 10, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ❗️ .env changes contains changes to env variables foundation high-risk Requires approval by Foundation team ready-for-e2e 💻 refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants