perf: refactor and replacing viewer.teams.getMinimal with viewer.teams.get#16552
Merged
perf: refactor and replacing viewer.teams.getMinimal with viewer.teams.get#16552
viewer.teams.getMinimal with viewer.teams.get#16552Conversation
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
force-pushed
the
refactor/use-get-teams
branch
from
665c9ad to
dd6f575
Compare
Udit-takkar
changed the title
viewer.teams.getMinimal with viewer.teams.getviewer.teams.getMinimal with viewer.teams.get
Udit-takkar
force-pushed
the
refactor/use-get-teams
branch
from
3705bfb to
9af75dc
Compare
Udit-takkar
commented
Oct 10, 2024
| input: TListMembersInputSchema; | ||
| }; | ||
|
|
||
| export const legacyListMembers = async ({ ctx, input }: ListMembersOptions) => { |
Contributor
Author
There was a problem hiding this comment.
legacyListMembers is the original listMembers function
Udit-takkar
commented
Oct 10, 2024
| const [searchText, setSearchText] = useState(""); | ||
|
|
||
| const members = trpc.viewer.teams.listMembers.useQuery({}); | ||
| const members = trpc.viewer.teams.legacyListMembers.useQuery({}); |
Contributor
Author
There was a problem hiding this comment.
I still need legacyListMembers because we need unique members from all the teams making sure a members of multiple team doesn't show up more than once but cursor and distinct property wasn't working properly
const teamMembers = await prisma.membership.findMany({
where: whereCondition,
select: {
id: true,
role: true,
accepted: true,
teamId: true,
user: { select: userSelect },
},
cursor: cursor ? { id: cursor } : undefined,
take: limit + 1,
orderBy: { id: "asc" },
distinct: ["userId"],
});
Contributor
Author
There was a problem hiding this comment.
TODO: remove legacyListMembers here and add a SQL query in a follow up PR
zomars
approved these changes
Oct 10, 2024
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Awesome work @Udit-takkar LGTM 🙏🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
Removing teams.getMinimal and teams.lazyLoadMembers introduced in this PR refactor: improve team members page performance #16155 .
Refactoring
listMembersendpoint to support fetching all the membersAlso Optimized OOO modal and Filter Container
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?