Skip to content

fix: update zoom integration doc to include user settings scope#16724

Merged
anikdhabal merged 5 commits intocalcom:mainfrom
vijayraghav-io:doc_for_#16709
Sep 21, 2024
Merged

fix: update zoom integration doc to include user settings scope#16724
anikdhabal merged 5 commits intocalcom:mainfrom
vijayraghav-io:doc_for_#16709

Conversation

@vijayraghav-io
Copy link
Copy Markdown
Contributor

What does this PR do?

Refer: #15489

Video showing to add user:read:settings scope in zoomAppMarketplace

https://www.loom.com/share/d1b8f6910ca946f7a729a80c78167da0?sid=7950171a-681c-45c4-9d7f-55aff7afe500

Video showing working as expected currently after #15489 merged
https://www.loom.com/share/48799d1d4af44de8ae82a6fff7353b0f?sid=8efbe50b-af43-4918-bbb7-4864a513b5ff

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • - N/A - I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 19, 2024

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Sep 19, 2024
@graphite-app graphite-app Bot requested a review from a team September 19, 2024 12:50
@github-actions github-actions Bot added the 🐛 bug Something isn't working label Sep 19, 2024
@dosubot dosubot Bot added the docs area: docs, documentation, cal.com/docs label Sep 19, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Sep 19, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (09/19/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/21/24)

1 label was added to this PR based on Keith Williams's automation.

Comment thread README.md Outdated
@Amit91848
Copy link
Copy Markdown
Member

Just wanted to confirm, we don't have that working currently in app.cal.com, and to make it work we have to add scope to the currently used credentials right?

Comment thread README.md
Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comment

Co-authored-by: Amit Sharma <74371312+Amit91848@users.noreply.github.com>
@vijayraghav-io
Copy link
Copy Markdown
Contributor Author

Just wanted to confirm, we don't have that working currently in app.cal.com, and to make it work we have to add scope to the currently used credentials right?

Scope needs to be updated in ZoomAppMarketplace for Cal App, nothing to update on Cal's credential.

Comment thread README.md Outdated
7. Now copy the Client ID and Client Secret to your `.env` file into the `ZOOM_CLIENT_ID` and `ZOOM_CLIENT_SECRET` fields.
8. Set the "OAuth Redirect URL" under "OAuth Information" as `<Cal.com URL>/api/integrations/zoomvideo/callback` replacing Cal.com URL with the URI at which your application runs.
9. Also add the redirect URL given above as an allow list URL and enable "Subdomain check". Make sure, it says "saved" below the form.
10. You don't need to provide basic information about your app. Instead click on "Scopes" and then on "+ Add Scopes". On the left, click the category "Meeting" and check the scope `meeting:write:meeting` and `user:read:settings`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user:read:settings is not part of the 'meeting' category, so what's the point of using 'and'? I suggested you make two points regarding this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's right, that's why i had added it in a separate point.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anikdhabal , updated can you please check.

Copy link
Copy Markdown
Member

@Amit91848 Amit91848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vijayraghav-io

@vijayraghav-io
Copy link
Copy Markdown
Contributor Author

LGTM! Thanks @vijayraghav-io

Thankyou! @Amit91848 🙏

@anikdhabal anikdhabal merged commit 16ca4dd into calcom:main Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync docs area: docs, documentation, cal.com/docs ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zoom integration doesn't follow the zoom app settings for auto-record

3 participants