feat: Add EXPAND accepting "team" in API V1 Bookings#16736
Merged
Conversation
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
Bot
added
api
| attendees: true, | ||
| user: true, | ||
| payment: true, | ||
| eventType: expand.includes("team") ? { include: { team: true } } : false, |
Member
Author
There was a problem hiding this comment.
Only show when req.expand contains "team".
| attendees: true, | ||
| user: true, | ||
| payment: true, | ||
| eventType: expand.includes("team") ? { include: { team: true } } : false, |
Member
Author
There was a problem hiding this comment.
only include when req.expand contains "team"
| @@ -0,0 +1,12 @@ | |||
| import { z } from "zod"; | |||
|
|
|||
| const expandEnum = z.enum(["team"]); | |||
Member
Author
There was a problem hiding this comment.
We can add more relations here, as we wish to allow expansion via expand parameter
Contributor
There was a problem hiding this comment.
?expand=team&expand=.. Have we considered a more industry standard param like select=? (Not a blocker just curious)
Comment on lines
+103
to
+105
| attendees: true, | ||
| user: true, | ||
| payment: true, |
Member
Author
There was a problem hiding this comment.
Not including them as part of the expand feature to avoid breaking changes. expand="team" should serve as a POC.
This comment was marked as resolved.
This comment was marked as resolved.
emrysal
approved these changes
Sep 20, 2024
Graphite Automations"Add ready-for-e2e label" took an action on this PR • (09/20/24)1 label was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the use of EXPAND to get relational data, POC includes using EXPAND with "team" to get eventType.team data returned on team events booked.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist