chore: Use no isolation for unit tests#16745
Merged
sean-brydon merged 7 commits intomainfrom Sep 20, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (09/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
keithwillcode
changed the title
sean-brydon
approved these changes
Sep 20, 2024
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
Took us a while to get the sweet spot!
LGTM
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed that the unit test runs take quite awhile to collect. This PR attempts to reduce that time by using --no-isolate and a 4vCPU machine.
transform 9.90s, setup 23.18s, collect 88.14s, tests 17.62s, environment 18.50s, prepare 8.70s
Mandatory Tasks (DO NOT REMOVE)