Skip to content

fix: translations for sidebar#16910

Merged
hbjORbj merged 2 commits into
mainfrom
fix/sidebar-translations
Oct 2, 2024
Merged

fix: translations for sidebar#16910
hbjORbj merged 2 commits into
mainfrom
fix/sidebar-translations

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Oct 2, 2024

What does this PR do?

  • Fixes CAL-4449
  • Routing forms is not using i18n
  • Korean translation for "Insights" is missing
Screenshot 2024-10-02 at 13 49 24

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@linear
Copy link
Copy Markdown

linear Bot commented Oct 2, 2024

CAL-4449 fix: translations for sidebar

@graphite-app graphite-app Bot requested a review from a team October 2, 2024 17:57
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 2, 2024
@dosubot dosubot Bot added the i18n area: i18n, translations label Oct 2, 2024
@hbjORbj hbjORbj added the 🐛 bug Something isn't working label Oct 2, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 2, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

keithwillcode
keithwillcode reviewed Oct 2, 2024
View reviewed changes
Comment thread apps/web/public/static/locales/en/common.json Outdated
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 6:00pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 6:00pm

@hbjORbj hbjORbj enabled auto-merge (squash) October 2, 2024 18:15
@hbjORbj hbjORbj merged commit 48a2fc2 into main Oct 2, 2024
@hbjORbj hbjORbj deleted the fix/sidebar-translations branch October 2, 2024 18:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 2, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

+1 more reviewer

@zomars zomars zomars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🐛 bug Something isn't working consumer core area: core, team members only i18n area: i18n, translations ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbjORbj @keithwillcode @zomars