Skip to content

fix: Salesforce assign event to organizer#16971

Merged
hbjORbj merged 3 commits intomainfrom
salesforce-assign-organizer-to-event
Oct 8, 2024
Merged

fix: Salesforce assign event to organizer#16971
hbjORbj merged 3 commits intomainfrom
salesforce-assign-organizer-to-event

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Refactors getSalesforceUserFromEmail

  • Assigns events to the organizer if they exist in Salesforce

  • Fixes #XXXX (GitHub issue number)

  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Install Salesforce
  • Create an event with a user that exists in Salesforce
    • The event should be assigned to the organizer
  • Create an event with a user that DOES NOT exist in Salesforce
    • The event should be assigned to the account that was used to connect Salesforce to Cal

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app Bot requested a review from a team October 7, 2024 14:22
@dosubot dosubot Bot added the crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid label Oct 7, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 7, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 7, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/08/24)

1 label was added to this PR based on Keith Williams's automation.

Comment thread packages/app-store/salesforce/lib/CrmService.ts Outdated
@PeerRich PeerRich added enterprise area: enterprise, audit log, organisation, SAML, SSO Urgent Created by Linear-GitHub Sync labels Oct 8, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 1:44pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 1:44pm

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @joeauyeung - nice one! Thanks for the assist @hbjORbj

@hbjORbj hbjORbj enabled auto-merge (squash) October 8, 2024 13:54
@hbjORbj hbjORbj merged commit e77a2f6 into main Oct 8, 2024
@hbjORbj hbjORbj deleted the salesforce-assign-organizer-to-event branch October 8, 2024 14:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 8, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e Urgent Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants