Skip to content

test: Add Attributes Routing e2e and some more unit tests#17032

Merged
hariombalhara merged 27 commits intomainfrom
add-e2e-attributes-routing
Oct 9, 2024
Merged

test: Add Attributes Routing e2e and some more unit tests#17032
hariombalhara merged 27 commits intomainfrom
add-e2e-attributes-routing

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Oct 9, 2024 •
edited
Loading

Add happy path e2e for testing the following flow:

  • Ability to use an Attribute in routing
  • Ability to test that attribute logic using Test Preview

Unit Tests

  • getRoutedHostsWithContactOwnerAndFixedHosts
  • getRoutedUsersWithContactOwnerAndFixedUsers
  • getUsersWithCredentialsConsideringContactOwner

hariombalhara and others added 24 commits September 24, 2024 15:18
@hariombalhara
Initial commit
e5e8a12
@hariombalhara
routingForm to Booking a particular team member working
03c0650
@hariombalhara
Happy path working
7c8b452
@hariombalhara
Fixes
fb3b263
@hariombalhara
Merge remote-tracking branch 'origin/main' into routing-forms-team-ev…
8a367da 
…ent-members-routing
@hariombalhara
Fix router query params forwarding
4bfb2b7
@hariombalhara
Merge remote-tracking branch 'origin/main' into routing-forms-team-ev…
73c9945 
…ent-members-routing
@hariombalhara
Add basicConfig within app
0c15120
@hariombalhara
Tests
9aed6f2
@hariombalhara
More tests
6b473e7
@hariombalhara @zomars
Update packages/app-store/routing-forms/components/SingleForm.tsx
bffc946 
Co-authored-by: Omar López <zomars@me.com>
@hariombalhara
Merge remote-tracking branch 'origin/main' into routing-forms-team-ev…
6c2b77d 
…ent-members-routing
@hariombalhara
Merge remote-tracking branch 'origin/routing-forms-team-event-members…
6559bc3 
…-routing' into routing-forms-team-event-members-routing
@hariombalhara
WIP
dcbfabc
@hariombalhara
Merge remote-tracking branch 'origin/main' into skip-contact-owner-ev…
6fd9751 
…en-if-it-matches-attribute-routing
@hariombalhara
Merge remote-tracking branch 'origin/main' into skip-contact-owner-ev…
f06be8c 
…en-if-it-matches-attribute-routing
@hariombalhara
Fix lint issues
489e1b2
@hariombalhara
Fix tests -TS and add new logic
be53242
@hariombalhara
Add getEventTypeRedirectUrl tests
5135fdd
@hariombalhara
Remove booking title changes code
b7f73c9
@hariombalhara
More changes
36e21fb
@hariombalhara
Add tests for getRoutedUsers
c216dda
@hariombalhara
Merge remote-tracking branch 'origin/main' into skip-contact-owner-ev…
331e2a8 
…en-if-it-matches-attribute-routing
@hariombalhara
More tests
59b2d00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add e2e attributes routing". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 9, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 4:34pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 4:34pm

@hariombalhara hariombalhara changed the title Add e2e attributes routing test: Add Attributes Routing e2e and some more unit tests Oct 9, 2024
@hariombalhara hariombalhara self-assigned this Oct 9, 2024
@hariombalhara hariombalhara added the automated-tests area: unit tests, e2e tests, playwright label Oct 9, 2024
@hariombalhara hariombalhara marked this pull request as ready for review October 9, 2024 16:18
@dosubot dosubot Bot added the routing-forms area: routing forms, routing, forms label Oct 9, 2024
@graphite-app graphite-app Bot requested a review from a team October 9, 2024 16:18
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 9, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode
Copy link
Copy Markdown
Contributor

keithwillcode commented Oct 9, 2024

@anikdhabal You want to review this since you have become our E2E wizard?

@anikdhabal
Copy link
Copy Markdown
Contributor

anikdhabal commented Oct 9, 2024

You want to review this since you have become our E2E wizard?

Yeah, I am reviewing it

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2024

E2E results are ready!

anikdhabal
anikdhabal approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🚀

@hariombalhara hariombalhara merged commit 06429e2 into main Oct 9, 2024
@hariombalhara hariombalhara deleted the add-e2e-attributes-routing branch October 9, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikdhabal anikdhabal anikdhabal approved these changes

Assignees

@hariombalhara hariombalhara

Labels

automated-tests area: unit tests, e2e tests, playwright core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hariombalhara @keithwillcode @anikdhabal