Skip to content

fix: API V1 Bookings, pick attendee id in response#17041

Merged
keithwillcode merged 1 commit intomainfrom
fix/add-attendee-id-in-booking-apiv1-resp
Oct 10, 2024
Merged

fix: API V1 Bookings, pick attendee id in response#17041
keithwillcode merged 1 commit intomainfrom
fix/add-attendee-id-in-booking-apiv1-resp

Conversation

@alishaz-polymath
Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath commented Oct 10, 2024 •
edited
Loading

What does this PR do?

Our attendee manipulation happens using attendee id but attendee id is not returned with the booking response making it way more complicated than it needs to be.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A -- I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 10, 2024
@dosubot dosubot Bot added the api area: API, enterprise API, access token, OAuth label Oct 10, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) October 10, 2024 15:21
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 10, 2024

Graphite Automations

"Add ready-for-e2e label" took an action on this PR • (10/10/24)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode merged commit 7529e33 into main Oct 10, 2024
@keithwillcode keithwillcode deleted the fix/add-attendee-id-in-booking-apiv1-resp branch October 10, 2024 15:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

@emrysal emrysal Awaiting requested review from emrysal

Assignees

No one assigned

Labels

api area: API, enterprise API, access token, OAuth core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alishaz-polymath @keithwillcode