chore: settings/my-account - remove pages router

[hbjORbj]

What does this PR do?

• Fixes CAL-4403
• remove pages router and use app router for all pages in settings/my-account
• remove env vars not needed anymore as a result

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• all settings/my-account/**/* pages must work as expected

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Oct 11, 2024 0:59am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Oct 11, 2024 0:59am

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Chore/remove pages router settings my account". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[linear]

CAL-4403 `settings/my-account` - Use app router and remove pages router

[keithwillcode]

We should split the next upgrade into a separate PR so that it’s more isolated and easier to revert out if needed

[github-actions]

E2E results are ready!

• Workflow #34432.1 latest results

[hbjORbj]

We should split the next upgrade into a separate PR so that it’s more isolated and easier to revert out if needed

Yessir, done

[emrysal]

@hbjORbj still seeing the same issue (very infrequently) - but also happens locally it seems.

[emrysal]

We gotta nail this 🙏

uncaughtException: TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed

Will keep reviewing, it's possible that the next upgrade has fixed the error.

[emrysal]

I've been working on out of this branch all day, numerous refreshes - hasn't crashed since the next.js upgrade.