Skip to content

feat: allow delete event-type platform atoms#17065

Merged
ThyMinimalDev merged 7 commits into
mainfrom
feat-platform-atoms-delete-event-type
Oct 15, 2024
Merged

feat: allow delete event-type platform atoms#17065
ThyMinimalDev merged 7 commits into
mainfrom
feat-platform-atoms-delete-event-type

Conversation

@ThyMinimalDev
Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev commented Oct 11, 2024 •
edited
Loading

What does this PR do?

Feat: allow deleting event-type in event type atom

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@dosubot dosubot Bot added event-types area: event types, event-types platform Anything related to our platform plan ✨ feature New feature or request labels Oct 11, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Oct 11, 2024
@graphite-app graphite-app Bot requested a review from a team October 11, 2024 11:16
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 11, 2024 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (10/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/14/24)

1 label was added to this PR based on Keith Williams's automation.

supalarry
supalarry previously approved these changes Oct 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with small notes

Comment thread packages/features/eventtypes/components/EventType.tsx Outdated
Comment thread packages/platform/atoms/hooks/event-types/private/useDeleteEventTypeById.ts Outdated
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 2:19pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 2:19pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 14, 2024 •
edited
Loading

E2E results are ready!

@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) October 15, 2024 12:34
Ryukemeister
Ryukemeister approved these changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ryukemeister Ryukemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, really dope one!

@ThyMinimalDev ThyMinimalDev merged commit 9c3f4ec into main Oct 15, 2024
@ThyMinimalDev ThyMinimalDev deleted the feat-platform-atoms-delete-event-type branch October 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibex088 ibex088 Awaiting requested review from ibex088

@supalarry supalarry Awaiting requested review from supalarry

1 more reviewer

@Ryukemeister Ryukemeister Ryukemeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core area: core, team members only event-types area: event types, event-types ✨ feature New feature or request platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ThyMinimalDev @supalarry @Ryukemeister @keithwillcode