feat: update github workflows to install playwright in a separate job#17070
Merged
keithwillcode merged 8 commits intoOct 15, 2024
Merged
Conversation
|
@Aditya-A-G is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
Bot
added
ci
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/11/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (10/11/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/15/24)1 label was added to this PR based on Keith Williams's automation. |
Contributor
|
Hey @Aditya-A-G, thanks for contributing can you please sign CLA? |
Contributor
Author
|
Hi @Praashh, I've signed the CLA. Thanks! |
Contributor
thanks, I'll do the final check. |
| if: ${{ needs.changes.outputs.has-files-requiring-all-checks == 'true' }} | ||
| uses: ./.github/workflows/yarn-install.yml | ||
|
|
||
| playwright: |
Contributor
There was a problem hiding this comment.
Looks good overall but let’s rename this to install-playwright
keithwillcode
previously approved these changes
Oct 15, 2024
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
keithwillcode
approved these changes
Oct 15, 2024
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves the Playwright installation into a separate job within the GitHub workflow. The goal is to prevent the Playwright installation from blocking other jobs like builds and unit tests that don't require it, reducing workflow time by around 40 seconds when cached.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?